Skip to content

Fix build#287

Closed
mihaip wants to merge 1 commit intoopenclaw:mainfrom
mihaip:main
Closed

Fix build#287
mihaip wants to merge 1 commit intoopenclaw:mainfrom
mihaip:main

Conversation

@mihaip
Copy link
Copy Markdown

@mihaip mihaip commented Feb 16, 2026

Fix build errors after refactoring from 957603e

Was getting errors similar to these on CI:

Error: internal/cmd/contacts_crud.go:258:32: cannot use given (variable of type bool) as string value in argument to strings.TrimSpace
Error: internal/cmd/contacts_crud.go:274:30: cannot use org (variable of type bool) as string value in argument to strings.TrimSpace
Error: internal/cmd/contacts_crud.go:410:48: cannot use c.Given (variable of type string) as bool value in argument to contactsApplyPersonName
Error: internal/cmd/contacts_crud.go:430:54: cannot use c.Organization (variable of type string) as bool value in argument to contactsApplyPersonOrganization

Fix build errors after refactoring from 957603e
Shehryar added a commit to Shehryar/gogcli that referenced this pull request Feb 17, 2026
The parameter lists for contactsApplyPersonName and
contactsApplyPersonOrganization used Go's grouped-type shorthand
incorrectly, causing `given` and `org` to be typed as bool instead of
string. This broke compilation on current Go versions.

Duplicates openclaw#287.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Shehryar Shehryar mentioned this pull request Feb 18, 2026
4 tasks
@steipete
Copy link
Copy Markdown
Collaborator

steipete commented Mar 7, 2026

Superseded by newer build-fix landings already on main, especially #355 for the current contacts/build regression. This branch is stale against current main, so closing instead of carrying another generic build-fix PR.

@steipete steipete closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants