fix(drive): delete command now moves to trash instead of permanent deletion#262
Merged
steipete merged 1 commit intoopenclaw:mainfrom Feb 15, 2026
Merged
Conversation
…letion
`drive delete` was calling `Files.Delete()` which permanently destroys
files. This contradicts the help text ("moves to trash") and user
expectations. The fix changes the default behavior to use
`Files.Update()` with `Trashed: true`, which moves files to trash
(recoverable for 30 days).
A new `--permanent` flag is added for users who explicitly want
irreversible deletion.
Fixes openclaw#261
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
…letion (openclaw#262) `drive delete` was calling `Files.Delete()` which permanently destroys files. This contradicts the help text ("moves to trash") and user expectations. The fix changes the default behavior to use `Files.Update()` with `Trashed: true`, which moves files to trash (recoverable for 30 days). A new `--permanent` flag is added for users who explicitly want irreversible deletion. Fixes openclaw#261 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drive deletecalledFiles.Delete()(permanent, irreversible) despite the help text stating "moves to trash"Files.Update()withTrashed: trueto move files to trash (recoverable for 30 days)--permanentfor users who explicitly want irreversible deletionChanges
DriveDeleteCmdgains a--permanentbool flag (defaultfalse)--permanent: callsFiles.UpdatewithTrashed: true(safe, recoverable)--permanent: callsFiles.Delete(irreversible, previous behavior)"Move a file to trash (use --permanent to delete forever)"trashed: truevsdeleted: true"trash drive file"vs"permanently delete drive file")Test plan
makebuilds successfullygo test ./internal/cmd/ -run TestDrive)Fixes #261
🤖 Generated with Claude Code