fix: recurring timezone fallback, attachment hardening, transport defaults#228
Closed
salmonumbrella wants to merge 5 commits intoopenclaw:mainfrom
Closed
fix: recurring timezone fallback, attachment hardening, transport defaults#228salmonumbrella wants to merge 5 commits intoopenclaw:mainfrom
salmonumbrella wants to merge 5 commits intoopenclaw:mainfrom
Conversation
This was referenced Feb 12, 2026
Closed
Remove unnecessary TLSClientConfig.Clone() since Transport.Clone() already deep-copies it. Add unit tests for sanitizeAttachmentFilename and resolveAttachmentOutputPath covering path traversal and edge cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use strconv.FormatBool in boolString to avoid goconst "true" literal - Rename shadowed err to writeErr in attachment test - Use http.NewRequestWithContext in transport test - Add blank lines before if statements per wsl_v5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
steipete
added a commit
that referenced
this pull request
Feb 14, 2026
Lands #228. Co-authored-by: salmonumbrella <182032677+salmonumbrella@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
steipete
added a commit
that referenced
this pull request
Feb 14, 2026
Lands #228. Co-authored-by: salmonumbrella <182032677+salmonumbrella@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Landed via #251. |
Collaborator
This was referenced Mar 7, 2026
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
Lands openclaw#228. Co-authored-by: salmonumbrella <182032677+salmonumbrella@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Etc/GMT±Ntimezone for recurring events when no regional IANA timezone matches the UTC offset (fixes offset datetimes losing timezone info)IsRegular()checkhttp.DefaultTransportinstead of barehttp.Transport{}to preserve proxy settings and connection pooling; addsupportsAllDrivesto drive deletesanitizeAttachmentFilenameandresolveAttachmentOutputPathwith adversarial inputs (traversal, dotdot, trailing separators)Fixes #216
Fixes #217
Fixes #223
Test plan
go test ./...passes (all packages green)../../etc/passwd,../secret.txt, absolute paths)🤖 Generated with Claude Code