Skip to content

Upgrade and adjust hotkeys keyboard shortcuts#1650

Merged
gregorydlogan merged 2 commits intoopencast:r/17.xfrom
ferishili:keyboard-shortcuts-fix-eth-issue-20
Nov 25, 2025
Merged

Upgrade and adjust hotkeys keyboard shortcuts#1650
gregorydlogan merged 2 commits intoopencast:r/17.xfrom
ferishili:keyboard-shortcuts-fix-eth-issue-20

Conversation

@ferishili
Copy link
Copy Markdown
Contributor

This PR consists of the following changes:

  • React-hotkeys-hook package upgrade: 4.6 to 5.2
  • Upgrade changes applied
  • Zoom in & out key-combo have been changed from z / t to e / r
  • Main focus to the current main menu applied to gain attention of hotkeys
  • Some places have now better shortcut behaviors by applying prevent defaults etc.

- react-hotkeys-hook package upgrade 4.6 to 5.2
- upgrade changes applied
- zoom in & out key-combo have been changed from z&t to e&r
- main focus to the current main menu applied to gain attention of hotkeys
- some places have now better shortcut behaviors by applying prevent defaults etc.
@ferishili ferishili requested a review from Arnei November 4, 2025 09:10
@ferishili ferishili self-assigned this Nov 4, 2025
@ferishili ferishili added type:bug Something isn't working type:enhancement New feature or request type:accessibility This would help impaired users type:usability Usability improvements labels Nov 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2025

This pull request is deployed at test.editor.opencast.org/1650/2025-11-04_10-32-15/ .
It might take a few minutes for it to become available.

@gregorydlogan gregorydlogan merged commit 5f46985 into opencast:r/17.x Nov 25, 2025
8 checks passed
@KatrinIhler
Copy link
Copy Markdown
Member

Is there a specific reason this was merged into 17.x?

@ferishili
Copy link
Copy Markdown
Contributor Author

Is there a specific reason this was merged into 17.x?

I think @Arnei could answer your question better :D

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Nov 28, 2025

No idea. Probably because it improves hotkey behaviour?

@KatrinIhler
Copy link
Copy Markdown
Member

Unless the prior behavior is a significant problem for people, I'd rather stuff like this goes into stable next time, especially since this changes hot keys.

Arnei added a commit that referenced this pull request Apr 15, 2026
Fix focus loss caused by sliders affecting keyboard shortcuts (follow-up to #1650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:accessibility This would help impaired users type:bug Something isn't working type:enhancement New feature or request type:usability Usability improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants