[3.0.x.x] replaced wget with curl ecb controller#13642
[3.0.x.x] replaced wget with curl ecb controller#13642AJenbo merged 2 commits intoopencart:3.0.x.xfrom
Conversation
|
Why? There was no bug! |
|
Not all serves include wget by default, but curl is part of the standard package set. |
You have tested currency update using hosting Cron? |
Yes, works fine on our webhost. |
|
With?
|
|
@condor2 try saying what error you get when you do that... |
Using wget will download a bunch of 0 kb files on server.
|
|
So that is 2 good reasons to switch to curl in favor of wget.
|
|
You are quick coming to the wrong conclusion. The original call was a simple wget -q "https://www.your-domain.com/index.php?route=extension/currency/ecb/refresh" for the CRON task, and it works perfectly fine, without generated zero-bytes files. What webhost doesn't have wget ? This one of the most common Linux/Unix commands available on webhosts. If you want to submit pull-requests for bugfixes, you are welcome, but please do some proper testing first, or at least provide some explanations. |
I have tested before. On my server download/generate zero-bytes files. so thats why I have tried with >/dev/null 2>&1, but same. So I use curl -s without zero-bytes files, but feel free to change back to wget -q |
|
According to wget --help: So ask your webhost to fix your wget then, we have run this command on countless servers/webhosts, never had this issue. |
)" This reverts commit bad5aa3.
You are quick to dismiss a problem with out understanding it.
Now it's
Which vendor is your wget from? It could be a different between for example the BusyBox and GNU implementation.
Lots. curl is part of the ubuntu-server meta package, wget is not, minimalistic setups based on ubuntu-server would be setup like that.
What is it that wasn't tested here? |
You are misunderstanding that description, "quiet (no output)" means nothing is printed on stdout, not that it will not generate a file. This is used to avoid clutter in the server logs, not to have it not save the downloaded file. I'm starting to think you are the one that didn't test this. To prevent wget from saving a file you need to give it something |
|
@AlenJo: OK, you right, the wget should indeed use the -q --no-check-certificate -O /dev/null . I stand corrected here! |
No description provided.