This repository was archived by the owner on Feb 18, 2025. It is now read-only.
API: transition into new terminology#1188
Merged
shlomi-noach merged 10 commits intomasterfrom Jun 9, 2020
Merged
Conversation
Collaborator
Author
|
It's best to review the changes hiding whitespace diffs, see https://github.com/openark/orchestrator/pull/1188/files?diff=unified&w=1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #1182 and #1187 : this PR changes the
InstanceAPI by adding new fields using "replica" terminology, on top of existing fields.This is done by adding
MarshalJSON()function which, at point of marshaling, updates new-terminology fields to the proper values.This is step 1 in transitioning into new terminology.
Clients are now able to use new terminology and drop usage of old terminology.
Future followups will be:
orchestratorbreaks.