Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Terminology changes#1182

Merged
shlomi-noach merged 4 commits intomasterfrom
more-terminology
Jun 5, 2020
Merged

Terminology changes#1182
shlomi-noach merged 4 commits intomasterfrom
more-terminology

Conversation

@shlomi-noach
Copy link
Collaborator

When this project moved into GitHub, I spent some weeks changing terminology from slave to replica where possible. This included variable names, URL path, CLI params, and more. I kept slave terminology where:

  • there was strong correlation to a MySQL command (e.g. stop slave)
  • in some API responses where I didn't want to break usage.

This PR (WIP) pushes forward:

  • In web interface, use replica
  • In failure analysis, use Replica rather than Slave, e.g. DeadMasterAndSomeReplicas instead of DeadMasterAndSomeSlaves
    This breaks compatibility for people who rely on the specific analysis type (== text).

There are still a couple public API facing fields unchanged in this PR.

@shlomi-noach shlomi-noach merged commit a8f7bcb into master Jun 5, 2020
@shlomi-noach shlomi-noach deleted the more-terminology branch June 5, 2020 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant