Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Update appplatform.json#2334

Merged
PhoenixHe-NV merged 1 commit intomasterfrom
PhoenixHe-msft-patch-7
Apr 15, 2021
Merged

Update appplatform.json#2334
PhoenixHe-NV merged 1 commit intomasterfrom
PhoenixHe-msft-patch-7

Conversation

@PhoenixHe-NV
Copy link
Copy Markdown

@PhoenixHe-NV PhoenixHe-NV commented Apr 15, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test bot commented Apr 15, 2021 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test bot commented Apr 15, 2021 •
edited
Loading

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 416d73c4615c40bdeb47a862e11d2fd98f030249. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️track2_azure-mgmt-appplatform [View full logs]  [Release SDK Changes] 
    info	[Changelog]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 416d73c4615c40bdeb47a862e11d2fd98f030249. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
  • ️✔️appplatform [View full logs]  [Release Schema Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 416d73c4615c40bdeb47a862e11d2fd98f030249. SDK Automation 14.0.0 
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️appplatform/mgmt/2020-07-01/appplatform [View full logs]  [Release SDK Changes] 
    info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Outbound`
info	[Changelog] - New const `Inbound`
info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
info	[Changelog] - New struct `RequiredTraffic`
info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
  • ️✔️preview/appplatform/mgmt/2020-11-01-preview/appplatform [View full logs]  [Release SDK Changes] 
    info	[Changelog] No exported changes
  • ️✔️preview/appplatform/mgmt/2019-05-01-preview/appplatform [View full logs]  [Release SDK Changes] 
    info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Inbound`
info	[Changelog] - New const `DeploymentResourceProvisioningStateDeleting`
info	[Changelog] - New const `Outbound`
info	[Changelog] - New const `Deleting`
info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
info	[Changelog] - New struct `RequiredTraffic`
info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
info	[Changelog] - New field `Sku` in struct `DeploymentResource`
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
info	[Changelog]
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 416d73c4615c40bdeb47a862e11d2fd98f030249. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.84 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.AppPlatform [View full logs]  [Release SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

This was referenced Apr 15, 2021
Closed
Closed
Closed
Closed
Closed
@PhoenixHe-NV PhoenixHe-NV merged this pull request into master Apr 15, 2021
@openapi-sdkautomation-test openapi-sdkautomation-test bot mentioned this pull request Apr 15, 2021
Closed
@PhoenixHe-NV
Copy link
Copy Markdown
Author

PhoenixHe-NV commented Apr 15, 2021

/azp run

This was referenced Apr 15, 2021
Open
Closed
Closed
Closed
Closed
Closed
@PhoenixHe-NV
Copy link
Copy Markdown
Author

PhoenixHe-NV commented Apr 15, 2021

/azp run

1 similar comment
@PhoenixHe-NV
Copy link
Copy Markdown
Author

PhoenixHe-NV commented Apr 15, 2021

/azp run

azure-sdk pushed a commit that referenced this pull request Apr 15, 2021
@azure-sdk
Update appplatform.json (#2334)
6313d10
azure-sdk pushed a commit that referenced this pull request Apr 16, 2021
@azure-sdk
Update appplatform.json (#2334)
ce04bc2
azure-sdk pushed a commit that referenced this pull request Apr 19, 2021
@azure-sdk
Update appplatform.json (#2334)
6343976
azure-sdk pushed a commit that referenced this pull request Apr 20, 2021
@azure-sdk
Update appplatform.json (#2334)
7afd2d3
azure-sdk pushed a commit that referenced this pull request May 10, 2021
@azure-sdk
Update appplatform.json (#2334)
719000b
azure-sdk pushed a commit that referenced this pull request May 10, 2021
@azure-sdk
Update appplatform.json (#2334)
d200771
azure-sdk pushed a commit that referenced this pull request May 11, 2021
@azure-sdk
Update appplatform.json (#2334)
a43277b
azure-sdk pushed a commit that referenced this pull request May 11, 2021
@azure-sdk
Update appplatform.json (#2334)
4426b6c
azure-sdk pushed a commit that referenced this pull request May 11, 2021
@azure-sdk
Update appplatform.json (#2334)
a6d79f1
azure-sdk pushed a commit that referenced this pull request May 11, 2021
@azure-sdk
Update appplatform.json (#2334)
91a4c0e
azure-sdk pushed a commit that referenced this pull request May 12, 2021
@azure-sdk
Update appplatform.json (#2334)
ca84bf9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PhoenixHe-NV