fix: transcribe verbosity#140
fix: transcribe verbosity#140jongwook merged 1 commit intoopenai:mainfrom nick-konovalchuk:fix-transcribe-verbosity
Conversation
|
I actually intended the two to be displayed even when |
|
@jongwook well, ETA is disabled when |
|
The language tag is returned in the result, but for those calling Regarding ETA: that's true; it's not the most intuitively named options but I thought both formats have merits (like below) and thought it'd be nice to have these verbose/concise output options, but probably better not mix up those two. We can maybe make it an integer level for verbosity if a totally silent output is desired by many .. |
|
@jongwook
|
|
I'd like to avoid magic string if possible. It's a bit unorthodox but I'm inclined to making it an I can make these edits on this PR if you'd like/don't mind. |
|
Don't bother yourself, I have nothing to do at the moment |
whisper/transcribe.py
Outdated
| previous_seek_value = seek | ||
|
|
||
| with tqdm.tqdm(total=num_frames, unit='frames', disable=verbose) as pbar: | ||
| with tqdm.tqdm(total=num_frames, unit='frames', disable=verbose is False) as pbar: |
There was a problem hiding this comment.
Could you make this verbose is not False? Thank you.

I've hidden "Detected langauge: " massage behind
verboseflag.Also fixed the flag usage with tqdm