Skip to content

[codex] Remove remote compaction failure log#27106

Merged
pakrym-oai merged 2 commits into
mainfrom
pakrym/remove-remote-compact-failure-log
Jun 9, 2026
Merged

[codex] Remove remote compaction failure log#27106
pakrym-oai merged 2 commits into
mainfrom
pakrym/remove-remote-compact-failure-log

Conversation

@pakrym-oai

Copy link
Copy Markdown
Collaborator

Why

log_remote_compact_failure was the only consumer of the compact-request logging payload and most of the token-usage breakdown fields. Once that failure log is removed, keeping the surrounding carrier types leaves dead plumbing in the compaction path and context manager.

What changed

  • Remove log_remote_compact_failure, CompactRequestLogData, and the v2 wrapper that only fed that log.
  • Let both remote compaction implementations return the original compaction error directly.
  • Replace TotalTokenUsageBreakdown with a narrow helper that returns only the remaining value needed by compaction analytics.
  • Keep estimate_response_item_model_visible_bytes private to the context manager implementation.

Validation

  • cargo check -p codex-core

@pakrym-oai pakrym-oai marked this pull request as ready for review June 9, 2026 02:23
@pakrym-oai pakrym-oai requested a review from a team as a code owner June 9, 2026 02:23
@pakrym-oai pakrym-oai merged commit 08cb633 into main Jun 9, 2026
31 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/remove-remote-compact-failure-log branch June 9, 2026 02:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants