build(v8): update rusty_v8 to 149.2.0#26464
Conversation
There was a problem hiding this comment.
💡 Codex Review
codex/patches/v8_bazel_rules.patch
Line 322 in 459c0d4
For Bazel builds targeting windows-gnullvm, @v8//bazel/config:is_windows is true, but the toolchain is GNU/clang-style rather than MSVC (.bazelrc's ci-windows-cross platform and this repo's V8 README both describe windows-gnullvm/x86_64-w64-windows-gnu). I checked clang's MinGW driver behavior with clang --target=x86_64-w64-windows-gnu -### ... /OPT:NOICF, and it treats /OPT:NOICF as an input path, so any Windows-GNU V8 build that reaches mksnapshot will fail before linking. Use the GNU/lld spelling for this branch (or select MSVC separately) instead of the MSVC /OPT:NOICF flag.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c1f0297 to
336d10b
Compare
No description provided.