Skip to content

fix: preserve auto review across config and delegation#26230

Merged
viyatb-oai merged 3 commits into
mainfrom
codex/viyatb/guardian-auto-review-continuity
Jun 8, 2026
Merged

fix: preserve auto review across config and delegation#26230
viyatb-oai merged 3 commits into
mainfrom
codex/viyatb/guardian-auto-review-continuity

Conversation

@viyatb-oai

@viyatb-oai viyatb-oai commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Why

Auto Review should remain the effective approval reviewer when settings cross runtime boundaries. A config or app-server round trip must not change the reviewer identity, and delegated work must not silently fall back to user review.

This requires both a stable canonical serialized value and propagation of the effective setting. auto_review is the canonical value across protocol and app-server output, while guardian_subagent remains accepted as backward-compatible input.

What changed

  • serialize ApprovalsReviewer::AutoReview consistently as auto_review across core protocol and app-server v2
  • continue accepting guardian_subagent when reading existing config or client requests
  • carry the active turn's approval reviewer into spawned agents
  • update config/debug expectations and add delegated-task regression coverage

Scope

This does not change Guardian policy or remove compatibility with existing guardian_subagent inputs. It preserves the selected reviewer across serialization, config reloads, app-server settings, and delegated task setup.

Related Guardian changes are split independently:

Validation

  • just test -p codex-app-server-protocol (224 passed)
  • regression coverage for delegated task reviewer propagation
  • serialization coverage for canonical auto_review output and legacy guardian_subagent input

Co-authored-by: Codex noreply@openai.com

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6528ccc95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/src/config_types.rs
Co-authored-by: Codex noreply@openai.com
@viyatb-oai viyatb-oai changed the title fix: preserve Auto Review across config and tasks fix: preserve auto review across config and tasks Jun 5, 2026
@viyatb-oai viyatb-oai changed the title fix: preserve auto review across config and tasks fix: preserve Auto Review across config and delegation Jun 5, 2026
@viyatb-oai viyatb-oai changed the title fix: preserve Auto Review across config and delegation fix: preserve auto review across config and delegation Jun 5, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@saud-oai

saud-oai commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jun 8, 2026
@viyatb-oai viyatb-oai enabled auto-merge (squash) June 8, 2026 18:57
@viyatb-oai viyatb-oai merged commit 9e0d7f0 into main Jun 8, 2026
32 of 35 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/guardian-auto-review-continuity branch June 8, 2026 18:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants