fix: preserve auto review across config and delegation#26230
Merged
Conversation
Co-authored-by: Codex noreply@openai.com
This was referenced Jun 3, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6528ccc95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex noreply@openai.com
jgershen-oai
approved these changes
Jun 5, 2026
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto Review should remain the effective approval reviewer when settings cross runtime boundaries. A config or app-server round trip must not change the reviewer identity, and delegated work must not silently fall back to user review.
This requires both a stable canonical serialized value and propagation of the effective setting.
auto_reviewis the canonical value across protocol and app-server output, whileguardian_subagentremains accepted as backward-compatible input.What changed
ApprovalsReviewer::AutoReviewconsistently asauto_reviewacross core protocol and app-server v2guardian_subagentwhen reading existing config or client requestsScope
This does not change Guardian policy or remove compatibility with existing
guardian_subagentinputs. It preserves the selected reviewer across serialization, config reloads, app-server settings, and delegated task setup.Related Guardian changes are split independently:
Validation
just test -p codex-app-server-protocol(224 passed)auto_reviewoutput and legacyguardian_subagentinput