[codex] Add OTEL counter descriptions#26091
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a531cb985
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ff23345 to
4b17850
Compare
This was referenced Jun 8, 2026
anp-oai
approved these changes
Jun 8, 2026
| const DURATION_UNIT: &str = "ms"; | ||
| const DURATION_DESCRIPTION: &str = "Duration in milliseconds."; | ||
|
|
||
| type InstrumentKey = (String, Option<String>); |
Collaborator
There was a problem hiding this comment.
nit: Could this be its own struct with named fields? All the traits that matter should be derive-able.
4b17850 to
a107f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Metric descriptions should be declared with reusable OTEL instruments instead of being coupled to individual consumers. Counter descriptions are the smallest API primitive needed by the exec-server observability work.
What changed
counter_with_descriptionwhile preserving the existing counter API.This PR only adds counter descriptions. It does not add gauges, second-based durations, or exec-server adoption.
Stack
Related independent coverage: #27059 tests OTLP HTTP log and trace event export.
The
codex-exec-serverbounded service tag now stays with the exec-server adoption change instead of this reusable infrastructure stack.Validation
just test -p codex-oteljust fix -p codex-oteljust fmt