Skip to content

Fix multiline paste in /goal edit#26047

Merged
etraut-openai merged 6 commits into
mainfrom
etraut/fix-goal-edit-paste-burst
Jun 3, 2026
Merged

Fix multiline paste in /goal edit#26047
etraut-openai merged 6 commits into
mainfrom
etraut/fix-goal-edit-paste-burst

Conversation

@etraut-openai

@etraut-openai etraut-openai commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes #26025.

Why

/goal edit opens CustomPromptView, which did not use the paste-burst handling that protects the main composer when terminals deliver paste as rapid key events. On Windows terminals, the first pasted newline could be treated as Enter-to-submit, truncating the goal edit and leaving the rest of the paste behind.

What

This reuses PasteBurst in CustomPromptView as a lightweight Enter-suppression detector for paste-like key streams. Characters still insert directly, explicit paste still goes through the view paste path, and ordinary text entry still submits on Enter.

@etraut-openai etraut-openai marked this pull request as ready for review June 3, 2026 05:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aec1eb1a13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/bottom_pane/custom_prompt_view.rs Outdated
Comment thread codex-rs/tui/src/bottom_pane/custom_prompt_view.rs Outdated
Comment thread codex-rs/tui/src/bottom_pane/custom_prompt_view.rs Outdated
Comment thread codex-rs/tui/src/bottom_pane/custom_prompt_view.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63acf27a9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/bottom_pane/custom_prompt_view.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a07ae1a28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/bottom_pane/custom_prompt_view.rs

@fcoury-oai fcoury-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested and worked as expected. Code looks good 👍

@etraut-openai etraut-openai merged commit a2a9e76 into main Jun 3, 2026
31 checks passed
@etraut-openai etraut-openai deleted the etraut/fix-goal-edit-paste-burst branch June 3, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating a goal with /goal edit misreads input when there is a newline in the pasted content

2 participants