TUI config cleanup: trusted projects#24255
Merged
Merged
Conversation
28ac7ec to
f7b2407
Compare
This was referenced May 24, 2026
fcoury-oai
approved these changes
May 25, 2026
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
Smoke test pass and code looks good, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TUI onboarding trusted-project persistence should go through the same app-server config write path as other config mutations. Writing
config.tomldirectly from the trust widget bypasses that layer and can let onboarding proceed even when the trust decision was not actually persisted.What changed
config/batchWrite.projects.<project>.trust_level = "trusted"using the existing project trust key helper.Verification
cargo test -p codex-tui --lib trust_persistence_failure_keeps_trust_step_in_progresscargo test -p codex-tui --lib trusted_project_edit_targets_project_trust_levelcodex-cli, accepted the trust prompt in a temp project, confirmedprojects.<project>.trust_level = "trusted", and simulated an unwritable config to verify onboarding stays on the trust screen without writing trust.