TUI config cleanup: oss_provider#24254
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8c6e98a0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b8c6e98 to
55275ca
Compare
This was referenced May 24, 2026
fcoury-oai
approved these changes
May 25, 2026
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
Smoke tested and code looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual provider selection during
codex --ossstartup was still persistingoss_providerthrough the legacy localconfig.tomlwriter. That bypasses the app-server-owned config mutation path used by the TUI, so this routes the write through the app server config API instead.The net behavior is intentionally narrow: only an interactive picker selection is persisted. Auto-detected single-running-provider startup and explicit
--local-providerstartup remain ephemeral, so merely having one backend running does not make that provider sticky for future runs.What Changed
set_default_oss_provider.oss_selectionreport whether the returned provider came from the interactive picker.oss_providerviaconfig/batchWriteonce the app server session is available.Verification
Manually smoke-tested the real
codex-tuibinary with a temporaryCODEX_HOME, pseudo-terminal input, and a fake LM Studio HTTP server:oss_provider = "lmstudio".--local-provider lmstudiostartup did not persistoss_provider.