Remove CODEX_RS_SSE_FIXTURE test hook#22413
Merged
Merged
Conversation
bolinfest
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CODEX_RS_SSE_FIXTURElet integration-style CLI, exec, and TUI tests bypass the normal Responses transport by reading SSE from local files. That kept test-only behavior wired through production client code. The affected tests can stay hermetic by using the existingcore_test_support::responsesmock server and passingopenai_base_urlinstead.What Changed
CODEX_RS_SSE_FIXTUREflag,codex_api::stream_from_fixture, theenv-flagsdependency, and the checked-in SSE fixture files.MockServerwith the existing SSE event constructors.Verification
cargo build -p codex-clicargo test -p codex-apicargo test -p codex-core --test all responses_api_stream_clicargo test -p codex-core --test all integration_creates_and_checks_session_filecargo test -p codex-exec --test all ephemeralcargo test -p codex-exec --test all resumecargo test -p codex-tui --test all resume_startup_does_not_consume_model_availability_nux_countjust bazel-lock-updatejust bazel-lock-checkjust fix -p codex-api -p codex-core -p codex-exec -p codex-tuigit diff --check