Skip to content

Remove CODEX_RS_SSE_FIXTURE test hook#22413

Merged
pakrym-oai merged 2 commits into
mainfrom
pakrym/remove-sse-fixture-tests
May 13, 2026
Merged

Remove CODEX_RS_SSE_FIXTURE test hook#22413
pakrym-oai merged 2 commits into
mainfrom
pakrym/remove-sse-fixture-tests

Conversation

@pakrym-oai

Copy link
Copy Markdown
Collaborator

Why

CODEX_RS_SSE_FIXTURE let integration-style CLI, exec, and TUI tests bypass the normal Responses transport by reading SSE from local files. That kept test-only behavior wired through production client code. The affected tests can stay hermetic by using the existing core_test_support::responses mock server and passing openai_base_url instead.

What Changed

  • Removed the CODEX_RS_SSE_FIXTURE flag, codex_api::stream_from_fixture, the env-flags dependency, and the checked-in SSE fixture files.
  • Repointed the affected core, exec, and TUI tests at MockServer with the existing SSE event constructors.
  • Removed the Bazel test data plumbing for the deleted fixtures and refreshed cargo/Bazel lock state.

Verification

  • cargo build -p codex-cli
  • cargo test -p codex-api
  • cargo test -p codex-core --test all responses_api_stream_cli
  • cargo test -p codex-core --test all integration_creates_and_checks_session_file
  • cargo test -p codex-exec --test all ephemeral
  • cargo test -p codex-exec --test all resume
  • cargo test -p codex-tui --test all resume_startup_does_not_consume_model_availability_nux_count
  • just bazel-lock-update
  • just bazel-lock-check
  • just fix -p codex-api -p codex-core -p codex-exec -p codex-tui
  • git diff --check

@pakrym-oai pakrym-oai marked this pull request as ready for review May 13, 2026 02:43
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 13, 2026 02:43
@pakrym-oai pakrym-oai enabled auto-merge (squash) May 13, 2026 02:55
@pakrym-oai pakrym-oai merged commit 96833c5 into main May 13, 2026
30 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/remove-sse-fixture-tests branch May 13, 2026 03:08
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants