feat(exec-server): use protobuf relay frames#22343
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f45499cfa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
starr-openai
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote exec-server now needs one executor websocket to serve multiple harness JSON-RPC sessions. Rendezvous routes by
stream_id, and the exec-server side needs to use the same stable relay frame contract instead of a hand-rolled JSON shape.The relay protocol also needs to make ownership boundaries clear: harness and executor endpoints own sequencing, acks, retries, duplicate suppression, segmentation, and reassembly; rendezvous only routes frames.
What Changed
codex.exec_server.relay.v1.RelayMessageFrameproto plus generated prost bindings forcodex-exec-server.ConnectionProcessorsessions keyed bystream_id.RemoteExecutorConfig::with_bearer_token(...)constructor for non-CLI callers and integration tests.ack/ack_bits, and endpoint responsibilities inexec-server/README.md.Verification
cargo test -p codex-exec-server --test relay multiplexed_remote_executor_routes_independent_virtual_streams -- --exactcargo test -p codex-exec-server --test relaycargo test -p codex-exec-serverpassed outside the sandbox. The sandboxed run hit macOSsandbox-exec: sandbox_apply: Operation not permittedin filesystem sandbox tests.