Conversation
starr-openai
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bazel CI was not actually exercising some sharded Rust integration-test targets on macOS. The
rules_rustsharding wrapper expects a symlink runfiles tree, but this repo runs Bazel with--noenable_runfiles. In that configuration the wrapper could fail to find the generated test binary, produce an empty test list, and exit successfully. That made targets such as//codex-rs/core:core-all-testlook green even when Cargo CI could still catch failures in the same Rust tests.The coverage gap appears to have been introduced by #18082, which enabled rules_rust native sharding on
//codex-rs/core:core-all-testand the other large Rust test labels. The manifest-runfiles setup itself predates that change in #10098, but #18082 is where the affected integration tests started running through the incompatible rules_rust sharding wrapper. #18913 fixed the same class of issue for wrapped unit-test shards, but integration-test shards were still going through the rules_rust wrapper until this PR.We still do not have the V8/code-mode pieces stable under the Bazel CI cross-compile setup, so this keeps those tests out of Bazel while restoring coverage for the rest of the sharded Rust integration suites. Cargo CI remains responsible for V8/code-mode coverage for now.
This change did uncover a real failing core test on
main:approved_folder_write_request_permissions_unblocks_later_apply_patch. That fix is split into #21060, which enables theapply_patchtool in the test, teaches the aggregate core test binary to dispatch the sandboxed filesystem helper, canonicalizes the macOS temp patch target, and isolates the core test harness from managed local/enterprise config. Keeping that fix separate lets this PR stay focused on restoring Bazel coverage while documenting the first failure it exposed.What changed
*-binbinaries and run them through the existing manifest-awareworkspace_root_testlauncher.suite::code_mode::.codex-rs/code-modeandcodex-rs/v8-pocunit-test targets frombazel.yml.Verification
bazel query --output=build //codex-rs/core:core-all-testnow showsworkspace_root_testwrapping//codex-rs/core:core-all-test-bin.bazel test --test_output=all --nocache_test_results --test_sharding_strategy=disabled //codex-rs/core:core-all-test --test_filter=suite::request_permissions_tool::approved_folder_write_request_permissions_unblocks_later_apply_patchruns the actual Rust test body and passes.bazel test --test_output=errors --nocache_test_results --test_env=CODEX_BAZEL_TEST_SKIP_FILTERS=suite::code_mode:: //codex-rs/core:core-all-testruns the sharded target with code-mode skipped and passes overall locally, with one flaky attempt retried by the existingflaky = Truesetting.