Conversation
starr-openai
approved these changes
May 4, 2026
dylan-hurd-oai
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Bazel test coverage change exposed
approved_folder_write_request_permissions_unblocks_later_apply_patch, andrust-ci-full.ymlshowed the same test failing onmainon macOS. There were two separate classes of problems here.Clean CI failure
The test emits an
apply_patchtool call, but its config did not enable theapply_patchtool, so the mocked response completed without anapply-patch-calloutput. After enabling the tool, the same path also needs the aggregatecodex-coretest binary to dispatch--codex-run-as-fs-helper; sandboxedapply_patchuses that helper under macOS Seatbelt.The test now also canonicalizes the temporary patch target before building the patch payload so the path matches normalized grants on macOS, where
/varpaths often normalize to/private/var.Local/enterprise config isolation
The core test harness now builds its default test config with managed config disabled, so host-managed enterprise config cannot alter these tests. The request-permissions turns in this test also explicitly use the user reviewer path, keeping the assertions focused on
request_permissionsbehavior rather than reviewer defaults from the host.What Changed
apply_patchinapproved_folder_write_request_permissions_unblocks_later_apply_patch.CODEX_FS_HELPER_ARG1, matching the existing apply-patch and linux-sandbox dispatch paths.ApprovalsReviewer::User.Verification
Run outside the Codex app sandbox because these macOS tests intentionally spawn Seatbelt:
cargo test -p codex-core approved_folder_write_request_permissions_unblocks_later_apply_patchcargo test -p codex-core approved_folder_write_request_permissions_unblocks_later_exec_without_sandbox_args