Skip to content

Support multi-env list_dir routing#20530

Closed
starr-openai wants to merge 1 commit intostarr/shell-command-env-routing-20260504from
starr/process-tools-remaining-env-tools-20260430
Closed

Support multi-env list_dir routing#20530
starr-openai wants to merge 1 commit intostarr/shell-command-env-routing-20260504from
starr/process-tools-remaining-env-tools-20260430

Conversation

@starr-openai
Copy link
Copy Markdown
Contributor

@starr-openai starr-openai commented Apr 30, 2026

Why

This PR is the list_dir slice of the multi-environment tool stack. Keeping it separate from shell, view_image, and apply_patch makes the review boundary one tool family wide.

Stack:

What changed

  • Exposes optional environment_id on list_dir only when multiple environments are selected.
  • Resolves the selected environment before filesystem access and routes directory reads through that environment filesystem.
  • Uses the selected environment cwd for read-deny matching and remote filesystem sandbox context.
  • Adds focused list_dir unit coverage plus remote-env routing coverage for empty, single, and multiple selected environments.

Verification

  • just fmt
  • git diff --check

Local Cargo validation is blocked by the Codex repo guardrail that requires devbox/Bazel validation instead of laptop-local Cargo.

@starr-openai starr-openai requested a review from a team as a code owner April 30, 2026 23:42
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from bb86a00 to b12b789 Compare May 1, 2026 01:56
@starr-openai starr-openai force-pushed the process-tools-stage2-envctx-envctx-gated-v1-medium branch 5 times, most recently from 1160244 to 22eef90 Compare May 1, 2026 02:16
@starr-openai starr-openai force-pushed the process-tools-stage2-envctx-envctx-gated-v1-medium branch 12 times, most recently from 0af9dc8 to 10c03f9 Compare May 1, 2026 04:35
Bojun-Vvibe added a commit to Bojun-Vvibe/oss-contributions that referenced this pull request May 1, 2026
…ini-cli)

- openai/codex#20564 — Enforce animations=false for screen readers (merge-as-is)
- openai/codex#20530 — Support multi-env filesystem tools (merge-after-nits)
- BerriAI/litellm#26956 — Fix MCP semantic filter native tool passthrough (merge-after-nits)
- google-gemini/gemini-cli#26277 — docs(sdk): add JSDoc to all exports (merge-as-is)
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from b12b789 to d4a8a2b Compare May 1, 2026 21:32
@starr-openai starr-openai changed the base branch from process-tools-stage2-envctx-envctx-gated-v1-medium to pr20314-process-tools-on-pr20281 May 1, 2026 21:32
@starr-openai starr-openai force-pushed the pr20314-process-tools-on-pr20281 branch from 3fa2aba to 6c964db Compare May 1, 2026 21:34
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from d4a8a2b to 8976c4a Compare May 1, 2026 21:34
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 8976c4a to bc45b5c Compare May 1, 2026 21:38
@starr-openai starr-openai force-pushed the pr20314-process-tools-on-pr20281 branch from 6c964db to 5c5dab3 Compare May 1, 2026 21:39
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from bc45b5c to 57186e5 Compare May 1, 2026 21:39
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 4a2eede to 59c7be7 Compare May 4, 2026 19:03
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 59c7be7 to d008943 Compare May 4, 2026 19:14
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from d008943 to df5d06d Compare May 4, 2026 19:37
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from df5d06d to 6c0bc24 Compare May 4, 2026 19:43
@starr-openai starr-openai force-pushed the pr20314-process-tools-on-pr20281 branch 2 times, most recently from 0810fe5 to ac26c8f Compare May 4, 2026 21:49
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 6c0bc24 to 53cd267 Compare May 4, 2026 22:45
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 53cd267 to 0fb60d1 Compare May 4, 2026 22:47
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 0080b3b to 10a5afd Compare May 4, 2026 22:54
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai added a commit that referenced this pull request May 4, 2026
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/process-tools-remaining-env-tools-20260430 branch from 10a5afd to 353fa86 Compare May 4, 2026 23:00
Co-authored-by: Codex <noreply@openai.com>
@starr-openai
Copy link
Copy Markdown
Contributor Author

Closing this follow-up because the targeted tool path has been removed; continuing the stack from #21142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant