Skip to content

Remove core protocol dependency [2/2]#20325

Merged
etraut-openai merged 3 commits into
mainfrom
etraut/tui-cleanup-pass2-2
Apr 30, 2026
Merged

Remove core protocol dependency [2/2]#20325
etraut-openai merged 3 commits into
mainfrom
etraut/tui-cleanup-pass2-2

Conversation

@etraut-openai

@etraut-openai etraut-openai commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Why

With the local model layer and app-server routing in place from PR1, this PR moves the active TUI runtime onto app-server notifications. The affected pieces share the same event flow, so the command surface, session state, bottom-pane prompts, chat rendering, history/status views, and tests move together to keep the stacked branch buildable.

This PR also removes the obsolete compatibility surface that is no longer used after the migration. The proposed protocol-boundary verifier layer was dropped from the stack; enforcing that final boundary will be simpler once codex-tui no longer needs any codex_protocol references.

This PR is part 2 of a 2-PR stack:

  1. Add TUI-owned replacement models and extract app-server event routing.
  2. Move the active TUI flow to app-server notifications and delete obsolete adapter code.

What changed

  • Rewired app command and session handling to use app-server request and notification shapes.
  • Moved approval overlays, request-user-input flows, MCP elicitation, realtime events, and review commands onto the app-server-facing model surface.
  • Updated chat rendering, history cells, status views, multi-agent UI, replay state, and TUI tests to use app-server notifications plus the local models introduced in PR1.
  • Deleted codex-rs/tui/src/app/app_server_adapter.rs and the superseded chatwidget/tests/background_events.rs fixture path.

Verification

  • cargo check -p codex-tui --tests
  • Top of stack: cargo test -p codex-tui

chatgpt-codex-connector[bot]

This comment was marked as outdated.

@etraut-openai etraut-openai force-pushed the etraut/tui-cleanup-pass2-1 branch from dc41aab to e9eaab1 Compare April 30, 2026 05:23
@etraut-openai etraut-openai force-pushed the etraut/tui-cleanup-pass2-2 branch from a5ccfea to 10a6f9a Compare April 30, 2026 05:23
@etraut-openai etraut-openai changed the title Remove core protocol dependency [2/10] Remove core protocol dependency [2/5] Apr 30, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10a6f9a34c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget/skills.rs Outdated
@etraut-openai etraut-openai force-pushed the etraut/tui-cleanup-pass2-2 branch from a5f839e to b1f993c Compare April 30, 2026 05:53
@etraut-openai etraut-openai force-pushed the etraut/tui-cleanup-pass2-1 branch from e9eaab1 to d57635e Compare April 30, 2026 06:54
@etraut-openai etraut-openai force-pushed the etraut/tui-cleanup-pass2-2 branch from b1f993c to 30b42c7 Compare April 30, 2026 06:54
@etraut-openai etraut-openai changed the title Remove core protocol dependency [2/5] Remove core protocol dependency [2/2] Apr 30, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 245b701731

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated

@fcoury-oai fcoury-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the help of codex, I was able to grasp and validate the code changes, which look good.

I ran some smoke tests as well against a temporary git repo, tested editing a file using shell execution and checked rendering/approval/status surfaces.

Approved.

Base automatically changed from etraut/tui-cleanup-pass2-1 to main April 30, 2026 17:52
@etraut-openai etraut-openai force-pushed the etraut/tui-cleanup-pass2-2 branch from 712f973 to ca7e78d Compare April 30, 2026 18:12
@etraut-openai etraut-openai merged commit f2bc2f2 into main Apr 30, 2026
25 checks passed
@etraut-openai etraut-openai deleted the etraut/tui-cleanup-pass2-2 branch April 30, 2026 18:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants