Remove core protocol dependency [2/2]#20325
Conversation
dc41aab to
e9eaab1
Compare
a5ccfea to
10a6f9a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10a6f9a34c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a5f839e to
b1f993c
Compare
e9eaab1 to
d57635e
Compare
b1f993c to
30b42c7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 245b701731
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
There was a problem hiding this comment.
With the help of codex, I was able to grasp and validate the code changes, which look good.
I ran some smoke tests as well against a temporary git repo, tested editing a file using shell execution and checked rendering/approval/status surfaces.
Approved.
712f973 to
ca7e78d
Compare
Why
With the local model layer and app-server routing in place from PR1, this PR moves the active TUI runtime onto app-server notifications. The affected pieces share the same event flow, so the command surface, session state, bottom-pane prompts, chat rendering, history/status views, and tests move together to keep the stacked branch buildable.
This PR also removes the obsolete compatibility surface that is no longer used after the migration. The proposed protocol-boundary verifier layer was dropped from the stack; enforcing that final boundary will be simpler once
codex-tuino longer needs anycodex_protocolreferences.This PR is part 2 of a 2-PR stack:
What changed
codex-rs/tui/src/app/app_server_adapter.rsand the supersededchatwidget/tests/background_events.rsfixture path.Verification
cargo check -p codex-tui --testscargo test -p codex-tui