Conversation
This was referenced Apr 24, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbc6c1beb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
viyatb-oai
reviewed
Apr 24, 2026
viyatb-oai
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ReadOnlyAccesswas a transitional legacy shape onSandboxPolicy:FullAccessmeant the historical read-only/workspace-write modes could read the full filesystem, whileRestrictedtried to carry partial readable roots. The partial-read model now belongs inFileSystemSandboxPolicyandPermissionProfile, so keeping it onSandboxPolicymakes every legacy projection reintroduce lossy read-root bookkeeping and creates unnecessary noise in the rest of the permissions migration.This PR makes the legacy policy model narrower and explicit:
SandboxPolicy::ReadOnlyandSandboxPolicy::WorkspaceWriterepresent the old full-read sandbox modes only. Split readable roots, deny-read globs, and platform-default/minimal read behavior stay in the runtime permissions model.What changed
ReadOnlyAccessfromcodex_protocol::protocol::SandboxPolicy, including the generatedaccessandreadOnlyAccessAPI fields.FileSystemSandboxPolicy/PermissionProfileentries.fullAccessread-access payloads by accepting and ignoring that no-op shape, while rejecting legacyrestrictedread-access payloads instead of silently widening them to full-read legacy policies.ReadOnlyAccess::Restricted.Verification
cargo check -p codex-app-server-protocol --testscargo check -p codex-windows-sandbox --testscargo test -p codex-app-server-protocol sandbox_policy_Stack created with Sapling. Best reviewed with ReviewStack.