Rename approvals reviewer variant to auto-review#19056
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dylan-hurd-oai
approved these changes
Apr 23, 2026
| #[serde(rename = "auto_review", alias = "guardian_subagent")] | ||
| #[strum(serialize = "auto_review")] | ||
| GuardianSubagent, | ||
| AutoReview, |
Collaborator
There was a problem hiding this comment.
do we still need the strum macro or the rename here?
Collaborator
Author
There was a problem hiding this comment.
yea i have to make this change in the next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
approvals_reviewernow usesauto_reviewas the canonical config/API value after #18504, but the Rust enum variant and nearby helper/test names still usedGuardianSubagent/ guardian approval wording. That made follow-up code and reviews confusing even though the external value had already moved to Auto-review.What changed
ApprovalsReviewer::GuardianSubagenttoApprovalsReviewer::AutoReview.auto_reviewremains the canonical serialized value.guardian_subagentremains accepted as a legacy alias.This intentionally does not rename the
[features].guardian_approvalkey,Feature::GuardianApproval,core/src/guardian, analytics event names, or app-server Guardian review event types.Verification
cargo test -p codex-protocol approvals_reviewer_serializes_auto_review_and_accepts_legacy_guardian_subagentcargo test -p codex-app-server-protocol approvals_reviewer_serializes_auto_review_and_accepts_legacy_guardian_subagentcargo test -p codex-config approvals_reviewercargo test -p codex-tui update_feature_flagscargo test -p codex-core permissions_instructionscargo test -p codex-tui permissions_selection