Rebrand approvals reviewer config to auto-review by won-openai · Pull Request #18504 · openai/codex

won-openai · 2026-04-18T21:03:55Z

Why

Auto-review is the user-facing name for the approvals reviewer, but the config/API value still exposed the old guardian_subagent name. That made new configs and generated schemas point users at Guardian terminology even though the intended product surface is Auto-review.

This PR updates the external approvals_reviewer value while preserving compatibility for existing configs and clients.

What changed

Makes auto_review the canonical serialized value for approvals_reviewer.
Keeps guardian_subagent accepted as a legacy alias.
Keeps user accepted and serialized as user.
Updates generated config and app-server schemas so approvals_reviewer includes:
- user
- auto_review
- guardian_subagent
Updates app-server README docs for the reviewer value.
Updates analytics and config requirements tests for the canonical auto_review value.

Compatibility

Existing configs and API payloads using:

approvals_reviewer = "guardian_subagent"

continue to load and map to the Auto-review reviewer behavior.

New serialization emits:

approvals_reviewer = "auto_review"

This PR intentionally does not rename the [features].guardian_approval key or broad internal Guardian symbols. Those are split out for a follow-up PR to keep this migration small and avoid touching large TUI/internal surfaces.

Verification
cargo test -p codex-protocol approvals_reviewer_serializes_auto_review_and_accepts_legacy_guardian_subagent
cargo test -p codex-app-server-protocol approvals_reviewer_serializes_auto_review_and_accepts_legacy_guardian_subagent

won-openai · 2026-04-19T17:07:01Z

@codex review

chatgpt-codex-connector · 2026-04-19T17:11:27Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 434eaa5597

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

won-openai · 2026-04-20T15:57:42Z

@codex review

chatgpt-codex-connector · 2026-04-20T16:05:47Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

won-openai · 2026-04-20T18:31:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf72dd1ac4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

won-openai · 2026-04-20T21:34:15Z

@codex review

chatgpt-codex-connector · 2026-04-20T21:41:24Z

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

won-openai · 2026-04-20T21:44:05Z

@codex review

won-openai · 2026-04-20T21:45:32Z

+        "ApprovalsReviewer".to_string()
+    }
+
+    fn json_schema(_generator: &mut SchemaGenerator) -> Schema {


This is manual because the normal schema generator does not know about legacy aliases. The code can read both auto_review and old guardian_subagent, but without this manual schema the generated schema would only list auto_review. That could make old configs fail schema checks even though the app can still read them.

won-openai · 2026-04-20T21:45:55Z

+        )
+    }
+}
+


This helper just writes out the schema by hand. It says: this value is a string, these are the allowed string values, and this is the description. We need that because the normal generated schema cannot include the old guardian_subagent value for us.

chatgpt-codex-connector · 2026-04-20T21:48:01Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T21:50:34Z

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

dylan-hurd-oai

1 comment about the enum value name itself, but otherwise lgtm

dylan-hurd-oai · 2026-04-22T06:43:05Z

    User,
+    #[serde(rename = "auto_review", alias = "guardian_subagent")]
+    #[strum(serialize = "auto_review")]
    GuardianSubagent,


why not change the enum value to AutoReview

having this on the follow up PR!

# Conflicts: # codex-rs/app-server-protocol/src/protocol/v2.rs

rebrand config

17e2979

won-openai marked this pull request as draft April 18, 2026 21:04

github-actions Bot mentioned this pull request Apr 19, 2026

📊 AI CLI 工具社区动态日报 2026-04-19 gsscsd/big_model_radar#209

Open

backwards compatibility

434eaa5

won-openai marked this pull request as ready for review April 20, 2026 00:23

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread codex-rs/features/src/lib.rs Outdated

github-actions Bot mentioned this pull request Apr 20, 2026

📊 AI CLI 工具社区动态日报 2026-04-20 gsscsd/big_model_radar#214

Open

Preserve guardian approval managed requirements

ac2b42a

config rebrand, backwards compatible

0f2f195

won-openai requested a review from a team as a code owner April 20, 2026 18:31

This comment was marked as spam.

Sign in to view

Merge origin/main into auto_review_rebrand

cf72dd1

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread codex-rs/protocol/src/config_types.rs Outdated

won-openai added 2 commits April 20, 2026 13:59

Fix auto-review compatibility regressions

59c625b

split PR for easy review

869ae2b

won-openai commented Apr 20, 2026

View reviewed changes

dylan-hurd-oai reviewed Apr 22, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into auto_review_rebrand

2d3b9f5

# Conflicts: # codex-rs/app-server-protocol/src/protocol/v2.rs

dylan-hurd-oai approved these changes Apr 22, 2026

View reviewed changes

won-openai added 3 commits April 22, 2026 12:54

Merge branch 'main' into auto_review_rebrand

810feda

Fix debug config auto-review expectation

f469c71

Fix TUI auto-review expectations

4215345

won-openai merged commit 46142c3 into main Apr 22, 2026
34 of 36 checks passed

won-openai deleted the auto_review_rebrand branch April 22, 2026 22:45

github-actions Bot locked and limited conversation to collaborators Apr 22, 2026

Conversation

won-openai commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changed

Compatibility

Uh oh!

won-openai commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

won-openai commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

won-openai commented Apr 20, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

won-openai commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

won-openai commented Apr 20, 2026

Uh oh!

won-openai Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

won-openai Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

dylan-hurd-oai left a comment

Choose a reason for hiding this comment

Uh oh!

dylan-hurd-oai Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

won-openai Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

won-openai commented Apr 18, 2026 •

edited

Loading

won-openai Apr 20, 2026 •

edited

Loading

won-openai Apr 20, 2026 •

edited

Loading