Publish standalone installer release archives#18910
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f2ce43a02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --package codex-responses-api-proxy \ | ||
| --package codex-sdk | ||
| --package codex-sdk \ | ||
| --standalone-output-dir dist/installer |
There was a problem hiding this comment.
I don't really love that this is a "feature" of the npm stuff rather than its own step. Can we assemble the right args so that stage_standalone_installer_archives.py is called in its own step? Would it be materially less efficient for some reason?
|
|
||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parent.parent | ||
| BUILD_SCRIPT = REPO_ROOT / "codex-cli" / "scripts" / "build_npm_package.py" |
There was a problem hiding this comment.
Again, I don't think this should be conflated with what we are doing in npm. Or if anything, this should be the source of truth and npm should depend on this?
|
@bolinfest fixed as per your feedback! |
3cb7390 to
85a00e8
Compare
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Summary
This PR adds release files that are made for the standalone installer.
This PR publishes those files during the Rust release:
codex-standalone-<platform>-<version>.tar.gzcodex-installer_SHA256SUMSEach standalone archive has the layout the installer needs directly. It contains
codex,rg, and the Windows helper binaries where needed.Stack
Design decisions
dist/installer.codex-installer_SHA256SUMS, look up the requested archive, verify it, then extract it.rusty_v8: stage artifacts, write a SHA-256 manifest next to them, and have consumers verify downloads against that manifest.Tests
Tests: workflow formatter check, Python compile checks, standalone archive staging smoke tests covering linux-x64, linux-arm64, darwin-x64, darwin-arm64, win32-x64, and win32-arm64 via synthetic vendor inputs, plus archive content checks for Unix and Windows layouts.