Migrate fork and resume reads to thread store#18900
Conversation
a1cf2fd to
3304803
Compare
6ab42ef to
0a97cbd
Compare
3304803 to
4684212
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4684212b00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1f08dd6 to
a32c66c
Compare
a32c66c to
344d17d
Compare
344d17d to
707e1f3
Compare
58068b9 to
070c747
Compare
707e1f3 to
17882c8
Compare
17882c8 to
a33177f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a33177f384
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a33177f to
22e9b89
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22e9b89dde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
21610d1 to
71885e6
Compare
71885e6 to
86dfb4b
Compare
86dfb4b to
b4e8ff8
Compare
b4e8ff8 to
aa5066a
Compare
aa5066a to
4a63d3d
Compare
4a63d3d to
35f560c
Compare
35f560c to
20ce4b4
Compare
20ce4b4 to
e801d87
Compare
e801d87 to
51786a8
Compare
| if !tokio::fs::try_exists(path).await.unwrap_or(false) { | ||
| return false; | ||
| } | ||
| read_thread_from_rollout_path(store, path.to_path_buf()) |
There was a problem hiding this comment.
surprised we need to double check ids. not sure how we ever get the missalignment
There was a problem hiding this comment.
in practice I hope it doesn't happen, but added a comment clarifying the case: basically this is a guard against rollout files being moved around without sqlite being updated.
I am going to need to do a pass at some point on reducing the number of reads in all of this code, because its currently pretty chatty and I think is going to be quite slow doing full-history reads against sediment. But for now, migration+safety.
51786a8 to
079c897
Compare
079c897 to
9298207
Compare
Uh oh!
There was an error while loading. Please reload this page.