[codex] Route live thread writes through ThreadStore by wiltzius-openai · Pull Request #18882 · openai/codex

wiltzius-openai · 2026-04-21T20:30:30Z

Begin migrating the thread write codepaths to ThreadStore.

This starts using ThreadStore inside of core session code, not only in the app server code.

Rework the interfaces around thread recording/persistence. We're left with the following:

ThreadManager: owns the process-level registry of loaded threads and handles cross-thread orchestration: start, resume, fork, lookup, remove, and route ops to running CodexThreads.
CodexThread: represents one loaded/running thread from the outside. It is the handle app-server and callers use to submit ops, inspect session metadata, and shut the thread down.
LiveThread: session-owned persistence lifecycle handle for one active thread. Core session code uses it to append rollout items, materialize lazy persistence, flush, shutdown, discard init-failed writers, and load that thread’s persisted history.
ThreadStore: storage backend abstraction. It answers “how are threads persisted, read, listed, updated, archived?” Local and remote implementations live behind this trait.
LocalThreadStore: local ThreadStore implementation. It owns the file/sqlite-specific details and keeps RolloutRecorder as a local implementation detail.

This is a few too many Thread abstractions for my liking, but they do all represent different concepts / needs / layers.

Migration note: in places where the core code explicitly requires a path, rather than a thread ID, throw an error if we're running with a remote store.

Cover the new local live-writer lifecycle with focused tests and preserve app-server thread-start behavior, including ephemeral pathless sessions.

wiltzius-openai · 2026-04-21T20:54:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 833bc89e61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-21T21:22:53Z

+    async fn create_thread(&self, _params: CreateThreadParams) -> ThreadStoreResult<()> {
        Err(not_implemented("create_thread"))
    }

-    async fn resume_thread_recorder(
-        &self,
-        _params: ResumeThreadRecorderParams,
-    ) -> ThreadStoreResult<Box<dyn ThreadRecorder>> {
-        Err(not_implemented("resume_thread_recorder"))
+    async fn resume_thread(&self, _params: ResumeThreadParams) -> ThreadStoreResult<()> {
+        Err(not_implemented("resume_thread"))
    }


Guard remote store selection until write APIs are implemented

Core session startup now requires ThreadStore::create_thread/resume_thread. When experimental_thread_store_endpoint is set, ThreadManager selects RemoteThreadStore, but these methods currently return not_implemented, causing non-ephemeral thread startup to fail immediately under that config.

Useful? React with 👍 / 👎.

yeah the remote thread store in non-functional, not worrying too much about it yet

wiltzius-openai · 2026-04-22T17:51:56Z

@codex review

wiltzius-openai · 2026-04-22T17:57:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/thread-store/src/local/update_thread_metadata.rs

Lines 152 to 153 in 124eabb

    
           find_thread_path_by_id_str(store.config.codex_home.as_path(), &thread_id.to_string()) 
        
               .await

Resolve metadata updates from the active thread path

persist_thread_memory_mode_update now depends on update_thread_metadata, which resolves rollouts by scanning codex_home only. Threads resumed from an explicit rollout path outside codex_home (supported by resume_thread_from_rollout) are not found, so memory-mode updates fail with thread not found despite an active resumed thread.

codex/codex-rs/core/src/thread_manager.rs

Line 794 in 124eabb

self.threads.write().await.remove(thread_id)

Shutdown persistence when removing threads directly

remove_thread now only drops the in-memory CodexThread. Live writers are owned by shared LocalThreadStore.live_recorders, and this path does not call shutdown_thread or discard_thread. Removing a thread after abnormal termination can therefore leave recorder entries and writer tasks alive indefinitely, leaking resources across the process lifetime.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-22T18:20:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 414ee8107f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-22T18:36:09Z

+                        LiveThread::create(
+                            Arc::clone(&thread_store),
+                            CreateThreadParams {
+                                thread_id: conversation_id,
+                                forked_from_id,
+                                source: session_source,
+                                base_instructions: BaseInstructions {
+                                    text: session_configuration.base_instructions.clone(),
+                                },
+                                dynamic_tools: session_configuration.dynamic_tools.clone(),
+                                event_persistence_mode,
+                            },
+                        )
+                        .await?
+                    }
+                    InitialHistory::Resumed(resumed_history) => {
+                        LiveThread::resume(
+                            Arc::clone(&thread_store),
+                            ResumeThreadParams {
+                                thread_id: resumed_history.conversation_id,
+                                rollout_path: Some(resumed_history.rollout_path.clone()),
+                                history: Some(resumed_history.history.clone()),
+                                include_archived: true,
+                                event_persistence_mode,
+                            },
+                        )
+                        .await?


Keep thread startup working with configured remote stores

Session::new now always creates/resumes persistence through the configured ThreadStore for non-ephemeral sessions. With experimental_thread_store_endpoint set, ThreadManager injects RemoteThreadStore, whose live-writer methods are still unimplemented; startup now fails immediately instead of launching the thread.

Useful? React with 👍 / 👎.

wiltzius-openai · 2026-04-22T18:41:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ab42ef34c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-22T18:54:18Z

+    async fn create_thread(&self, _params: CreateThreadParams) -> ThreadStoreResult<()> {
        Err(not_implemented("create_thread"))
    }

-    async fn resume_thread_recorder(
-        &self,
-        _params: ResumeThreadRecorderParams,
-    ) -> ThreadStoreResult<Box<dyn ThreadRecorder>> {
-        Err(not_implemented("resume_thread_recorder"))
+    async fn resume_thread(&self, _params: ResumeThreadParams) -> ThreadStoreResult<()> {
+        Err(not_implemented("resume_thread"))


Implement remote thread lifecycle methods

RemoteThreadStore::create_thread/resume_thread now return not_implemented, but session startup now routes live persistence through ThreadStore. With experimental_thread_store_endpoint set, ThreadManager picks RemoteThreadStore, and non-ephemeral Session::new calls these methods during init. This makes remote-backed sessions fail to start.

Useful? React with 👍 / 👎.

wiltzius-openai · 2026-04-22T21:06:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/core/src/session/handlers.rs

Lines 974 to 978 in 0a97cbd

    
           let event = Event { 
        
               id: sub_id, 
        
               msg: EventMsg::ShutdownComplete, 
        
           }; 
        
           sess.send_event_raw(event).await;

Skip persisting shutdown event after closing live writer

shutdown() closes thread persistence and then emits ShutdownComplete via send_event_raw, which always tries to persist. Because the live writer was already removed, this path hits ThreadNotFound and logs a persistence error on normal shutdowns. That creates false-positive error logs and obscures real persistence issues.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pakrym-oai · 2026-04-22T22:49:41Z

            restriction_product,
        ));
        let skills_watcher = build_skills_watcher(Arc::clone(&skills_manager));
+        let thread_store = configured_thread_store(config);


nit: should this be selected at even higher level?

pakrym-oai · 2026-04-22T23:05:23Z

+            otel.name = "session_init.thread_persistence",
+            session_init.ephemeral = config.ephemeral,
+        ));
+        let state_db_fut = async {


worth having on the abstraction? at least for now?

downcast doesn't make it much better

It went in and out a couple times as I revised.... agreed the downcast isn't much better but I wanted to push the failure / issue as early in the code flow as possible. I.e. make sure its clear that accessing state_db_fut in the session.rs code is not something the code out here should be doing; otherwise it's easy to just keep accessing it...

to make it more obvious, I removed the default case that was still instantiating the state db. If you're running a local thread store you get one, otherwise (ephemeral or remote thread store) it's just None / we'll burn down what fails

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 0fe48a3 to 833bc89 Compare April 21, 2026 20:48

wiltzius-openai marked this pull request as ready for review April 21, 2026 21:08

wiltzius-openai requested a review from a team as a code owner April 21, 2026 21:08

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 833bc89 to 792c0f8 Compare April 21, 2026 21:32

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/thread_manager.rs

Comment thread codex-rs/thread-store/src/local/mod.rs Outdated

Comment thread codex-rs/core/src/session/session.rs Outdated

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address PR review feedback (#18882)

414ee81

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address follow-up review feedback (#18882)

6ab42ef

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address PR review feedback (#18882)

1226b18

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address follow-up review feedback (#18882)

7564a8e

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address latest live thread review feedback (#18882)

0a97cbd

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 6ab42ef to 0a97cbd Compare April 22, 2026 21:06

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/thread_manager.rs

Comment thread codex-rs/core/src/thread_manager.rs Outdated

Comment thread codex-rs/core/src/session/session.rs

Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated

pakrym-oai reviewed Apr 22, 2026

View reviewed changes

Comment thread codex-rs/tui/src/app/tests.rs Outdated

pakrym-oai reviewed Apr 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/session/mod.rs Outdated

pakrym-oai reviewed Apr 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/live_thread.rs Outdated

pakrym-oai reviewed Apr 22, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address live thread review feedback (#18882)

85ba62e

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: pass thread store into spawn path (#18882)

45384c8

pakrym-oai reviewed Apr 23, 2026

View reviewed changes

Comment thread codex-rs/core/src/session/session.rs Outdated

pakrym-oai approved these changes Apr 23, 2026

View reviewed changes

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 7233b25 to e338f77 Compare April 23, 2026 01:58

wiltzius-openai added 14 commits April 23, 2026 09:28

Route live thread writes through ThreadStore

d2074ad

Fix memory mode test sqlite home

8e28ba9

Add explicit thread discard lifecycle

2f2460a

Tighten thread store live writer boundaries

4570bf7

Clarify rollout path fallback behavior

5bf06d3

Discard live thread writer on init failures

8be90d7

Introduce live thread persistence owner

f2db02f

Rename local thread live writer module

98f4e6c

codex: address PR review feedback (#18882)

9eeb1b6

codex: address follow-up review feedback (#18882)

f0ef805

codex: address latest live thread review feedback (#18882)

564a492

codex: address live thread review feedback (#18882)

83894c6

codex: pass thread store into spawn path (#18882)

6c491a0

codex: address live thread review comments

070c747

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 58068b9 to 070c747 Compare April 23, 2026 16:33

wiltzius-openai merged commit f1923a3 into main Apr 23, 2026
25 of 26 checks passed

wiltzius-openai deleted the wiltzius/codex/thread-store-live-writes branch April 23, 2026 17:17

github-actions Bot locked and limited conversation to collaborators Apr 23, 2026

	find_thread_path_by_id_str(store.config.codex_home.as_path(), &thread_id.to_string())
	.await

	let event = Event {
	id: sub_id,
	msg: EventMsg::ShutdownComplete,
	};
	sess.send_event_raw(event).await;

Conversation

wiltzius-openai commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wiltzius-openai commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

wiltzius-openai Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wiltzius-openai commented Apr 22, 2026

Uh oh!

wiltzius-openai commented Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wiltzius-openai commented Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wiltzius-openai commented Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wiltzius-openai commented Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pakrym-oai Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

pakrym-oai Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

pakrym-oai Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

wiltzius-openai Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

wiltzius-openai Apr 23, 2026

wiltzius-openai commented Apr 21, 2026 •

edited

Loading