show bash mode in the TUI#18271
Merged
Merged
Conversation
abhinav-oai
added a commit
that referenced
this pull request
Apr 17, 2026
Add the missing argument comment on the regression test cursor position literal. Co-authored-by: Codex <noreply@openai.com>
abhinav-oai
commented
Apr 18, 2026
| fn shell_mode_footer_line(&self) -> Option<Line<'static>> { | ||
| self.is_bang_shell_command() | ||
| .then_some(()) | ||
| .map(|_| Line::from(vec![Span::from("Bash mode").light_red()])) |
Collaborator
Author
There was a problem hiding this comment.
btw the copy is just this now, no more (! to toggle) since it's not really a toggle but actually a prefix
fcoury-oai
requested changes
Apr 20, 2026
Move shell-prefix handling into ChatComposer and drop the generic hidden-prefix textarea APIs. Co-authored-by: Codex <noreply@openai.com>
Prevent absorbed bang commands from entering slash-command flows, preserve history navigation from the visible start of recalled shell drafts, and satisfy the argument comment lint. Co-authored-by: Codex <noreply@openai.com>
Add the missing argument comment on the regression test cursor position literal. Co-authored-by: Codex <noreply@openai.com>
515924f to
99c73c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Plan mode (shift + tab to cycle)›composer prefix with a bang!Why