Adjust default tool search result caps#17684
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
262ed4f to
d741ec6
Compare
40b6b7c to
b60b202
Compare
shijie-oai
reviewed
Apr 14, 2026
da8d14e to
06c5933
Compare
shijie-oai
approved these changes
Apr 14, 2026
shijie-oai
reviewed
Apr 14, 2026
06c5933 to
1183521
Compare
shijie-oai
reviewed
Apr 14, 2026
shijie-oai
reviewed
Apr 14, 2026
Comment on lines
+112
to
+113
| limit: usize, | ||
| use_default_limit: bool, |
Collaborator
There was a problem hiding this comment.
very small nit and we can address as followup to unblock - I don't see the point of unpacking and unwrap with fallback at line 73 to be fair.
shijie-oai
approved these changes
Apr 14, 2026
1183521 to
8a237cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test -p codex-core tool_search