Conversation
7063b84 to
f573b67
Compare
bd37f95 to
e0f9212
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
7961f57 to
da7306d
Compare
Co-authored-by: Codex <noreply@openai.com>
da7306d to
657d6b2
Compare
|
@codex review this |
codex-rs/tui/src/slash_command.rs
Outdated
| SlashCommand::Model => "choose what model and reasoning effort to use", | ||
| SlashCommand::Personality => "choose a communication style for Codex", | ||
| SlashCommand::Realtime => "toggle realtime voice mode (experimental)", | ||
| SlashCommand::Audio => "select microphone/speaker for realtime voice", |
There was a problem hiding this comment.
I almost want /settings.
There was a problem hiding this comment.
Don't want to add a new command for each new setting.
| use super::*; | ||
| use crate::app_event::AppEvent; | ||
| use crate::app_event::ExitMode; | ||
| #[cfg(all(not(target_os = "linux"), feature = "voice-input"))] |
There was a problem hiding this comment.
let's not add feature build, @bolinfest just cleaned them all out
codex-rs/tui/src/slash_command.rs
Outdated
| SlashCommand::Model => "choose what model and reasoning effort to use", | ||
| SlashCommand::Personality => "choose a communication style for Codex", | ||
| SlashCommand::Realtime => "toggle realtime voice mode (experimental)", | ||
| SlashCommand::Audio => "select microphone/speaker for realtime voice", |
There was a problem hiding this comment.
Hide when feature is not enabled.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 657d6b29f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !self.realtime_conversation.is_live() { | ||
| return; |
There was a problem hiding this comment.
Reject restart requests once realtime conversation is stopping
restart_realtime_audio_device only checks is_live(), and is_live() includes the Stopping phase. But request_realtime_conversation_close() already stops local audio immediately. If /audio changes are applied during shutdown, selecting restart can re-enable mic/speaker after the user asked realtime to stop, causing unexpected capture/playback until close completes.
Useful? React with 👍 / 👎.
codex-rs/tui/src/app_event.rs
Outdated
| }, | ||
|
|
||
| /// Persist the selected realtime microphone or speaker to top-level config. | ||
| #[cfg(all(not(target_os = "linux"), feature = "voice-input"))] |
There was a problem hiding this comment.
let's avoid all cross complitation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
59019fb to
9619843
Compare
Summary
Validation