Merged
Conversation
Add microphone and speaker selection config for realtime audio. Co-authored-by: Codex <noreply@openai.com>
7063b84 to
f573b67
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review this |
pakrym-oai
reviewed
Feb 26, 2026
codex-rs/core/src/config/mod.rs
Outdated
| fn realtime_audio_loads_from_config_toml() -> std::io::Result<()> { | ||
| let cfg: ConfigToml = toml::from_str( | ||
| r#" | ||
| [realtime.audio] |
Contributor
There was a problem hiding this comment.
Summary
- Updated config parsing to accept realtime device preferences under a top-level
audiotable (ConfigToml.audio) and wired runtime loading to read fromcfg.audiodirectly when buildingrealtime_audio. codex-rs/core/src/config/mod.rsL1184-L1187 codex-rs/core/src/config/mod.rsL2173-L2178 - Updated config edit persistence so
set_realtime_microphone/set_realtime_speakernow write to[audio], and updated the config edit test assertions accordingly. codex-rs/core/src/config/edit.rsL842-L863 codex-rs/core/src/config/edit.rsL1832-L1873 - Updated the config TOML loading test to use
[audio]and regenerated the schema soaudiois represented as a top-level config key inconfig.schema.json. codex-rs/core/src/config/mod.rsL6005-L6033 codex-rs/core/config.schema.jsonL1550-L1558
Testing
- ✅
cd /workspace/codex/codex-rs && just write-config-schema - ✅
cd /workspace/codex/codex-rs && just fmt - ✅
cd /workspace/codex/codex-rs && cargo build -p codex-linux-sandbox - ✅
cd /workspace/codex/codex-rs && cargo test -p codex-core config::tests::realtime_audio_loads_from_config_toml - ✅
cd /workspace/codex/codex-rs && cargo test -p codex-core config::edit::tests::blocking_builder_set_realtime_audio_persists_and_clears ⚠️ cd /workspace/codex/codex-rs && cargo test -p codex-core realtime_audio(fails onsuite::realtime_conversation::inbound_spawn_transcript_starts_turn_and_does_not_block_realtime_audiowith a timeout in this environment)
Committed on branch work as:
222664c — Switch realtime audio config to top-level audio table
Also created a follow-up PR entry via make_pr:
“Follow-up: move realtime audio config to top-level [audio]”.
pakrym-oai
approved these changes
Feb 26, 2026
Contributor
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation