Ktorfit Cleanup: Remove Duplicates and Align DI Configuration #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthkumarJ
approved these changes
Aug 5, 2025
biplab1
approved these changes
Aug 5, 2025
Contributor
biplab1
left a comment
There was a problem hiding this comment.
Looks good to me. Assuming all APIs are fetching and displaying correctly, since the screen recording isn’t uploaded.
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-449
https://github.com/user-attachments/assets/b45e7d24-0e6c-4ff7-b267-ed2b88434dfd