feat: Migrate [core/database] to KMP #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
approved these changes
Apr 5, 2025
Collaborator
|
@itsPronay App is running as expected right |
Collaborator
Author
@niyajali, it's working fine now! Previously I was getting an error because I didn't provide a type for MifosDatabase, which caused Koin to not detect it. But right now, in some screens we having ktor related issues. Other than that, everything is working as expected |
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* [core.database] to KMP * dependencyGuardBaseline generated * provided type for mifosdatabase + refactored
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* [core.database] to KMP * dependencyGuardBaseline generated * provided type for mifosdatabase + refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-407
Screenrecorder-2025-04-05-08-31-04-972.mp4
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.