feat - Migrate hilt to koin #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
requested changes
Mar 25, 2025
niyajali
requested changes
Mar 25, 2025
niyajali
requested changes
Mar 27, 2025
build-logic/convention/src/main/kotlin/KoinAndroidConventionPlugin.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/di/RepositoryModule.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repositoryImp/ChargeDialogRepositoryImp.kt
Outdated
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/di/DatabaseModule.kt
Outdated
Show resolved
Hide resolved
core/domain/src/main/java/com/mifos/core/domain/di/UseCaseModule.kt
Outdated
Show resolved
Hide resolved
core/domain/src/main/java/com/mifos/core/domain/useCases/ActivateSavingsUseCase.kt
Show resolved
Hide resolved
core/domain/src/main/java/com/mifos/core/domain/useCases/ApproveSavingsApplicationUseCase.kt
Show resolved
Hide resolved
core/domain/src/main/java/com/mifos/core/domain/useCases/DeleteClientAddressPinpointUseCase.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/mifos/core/domain/useCases/GetGroupSavingsAccountTemplateByProductUseCase.kt
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/di/NetworkModule.kt
Outdated
Show resolved
Hide resolved
niyajali
requested changes
Mar 27, 2025
build-logic/convention/src/main/kotlin/KoinAndroidConventionPlugin.kt
Outdated
Show resolved
Hide resolved
niyajali
approved these changes
Mar 28, 2025
Collaborator
niyajali
left a comment
There was a problem hiding this comment.
@itsPronay Run the app and upload a video
core/common/src/main/java/com/mifos/core/common/network/di/DispatchersModule.kt
Show resolved
Hide resolved
Collaborator
Author
sent on slack dada |
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* Replaced hilt with koin in feature module * Added RepositoryModule * migrated Dispatchers use * replaced hilt with koin in core.domain * network and database * removed hilt from repo impl * migrated hilt to koin * backup * backup * added helperModule * network module + database modules left out part * fix checks * app builds fine now * fix app crash + added missing modules * removed commented out code * removed comments * made suggested changes * changed Files to make app run * updated --------- Co-authored-by: revanthkumarJ <jrevanth101@gmail.com>
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* Replaced hilt with koin in feature module * Added RepositoryModule * migrated Dispatchers use * replaced hilt with koin in core.domain * network and database * removed hilt from repo impl * migrated hilt to koin * backup * backup * added helperModule * network module + database modules left out part * fix checks * app builds fine now * fix app crash + added missing modules * removed commented out code * removed comments * made suggested changes * changed Files to make app run * updated --------- Co-authored-by: revanthkumarJ <jrevanth101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-405
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Screenrecorder-2025-03-28-13-06-15-40.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.