feat: Migrate :core:ui to KMP #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@revanthkumarJ there are so many missing components like buttons, and basic components. add them by seeing from mifos mobile or mifos pay as I can see in screens, we are using Button and some components directly. |
Contributor
Author
|
ok @Nagarjuna0033 I will implement them based on wallet and mobile |
Contributor
Author
|
@Nagarjuna0033 review it once added all the required components |
# Conflicts: # core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosEmptyUi.kt # core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosFAB.kt # core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosToolbar.kt # core/ui/src/commonMain/kotlin/com/mifos/core/ui/util/DevicePreview.kt # core/ui/src/main/java/com/mifos/core/ui/util/GroupListPreviewParameterProvider.kt # core/ui/src/main/java/com/mifos/core/ui/util/SearchResultPreviewParameter.kt # feature/search/src/main/java/com/mifos/feature/search/SearchScreen.kt # mifosng-android/dependencies/demoDebugCompileClasspath.txt # mifosng-android/dependencies/demoReleaseCompileClasspath.txt # mifosng-android/dependencies/prodDebugCompileClasspath.txt # mifosng-android/dependencies/prodReleaseCompileClasspath.txt
Nagarjuna0033
approved these changes
Mar 24, 2025
Collaborator
|
@revanthkumarJ I think the app should run could you check if it is upload video or image. |
Contributor
Author
|
@niyajali ok brother |
Contributor
Author
Contributor
Author
|
@niyajali can you please run the workflows and merge this PR , if everything is fine |
therajanmaurya
approved these changes
Mar 27, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* UI Converted to KMP * updated * updated * added other components * updated * updated * updated * updated * merged
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* UI Converted to KMP * updated * updated * added other components * updated * updated * updated * updated * merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#401
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.