Skip to content

fix(model-selector): prevent saving empty default model#308

Merged
tjbck merged 4 commits intoopen-webui:mainfrom
anuraagdjain:fix/model-saving
Dec 28, 2023
Merged

fix(model-selector): prevent saving empty default model#308
tjbck merged 4 commits intoopen-webui:mainfrom
anuraagdjain:fix/model-saving

Conversation

@anuraagdjain
Copy link
Contributor

  • throw a toast error when user is trying to click on set as default without actually choosing the model(s).
  • feat: added hmr for local development. use npm run dev and you get page reload + backend functionality without needing to build every time for small changes.
Screen.Recording.2023-12-28.at.6.07.28.PM.mov

anuraagdjain and others added 2 commits December 28, 2023 18:06
- throw a toast error when user is trying to click on `set as default` without actually choosing the model(s).
- feat: added hmr for local development. use `npm run dev` and you get the hmr when debugging.
@tjbck
Copy link
Contributor

tjbck commented Dec 28, 2023

Thanks for your PR and your amazing work! everything LGTM, but I believe hmr should be turned on by default? was that not the case for you?

@anuraagdjain
Copy link
Contributor Author

Thanks for your PR and your amazing work! everything LGTM, but I believe hmr should be turned on by default? was that not the case for you?

Did a clean install again and it worked without explicitly needing the hmr in vite.config, so reverted that change.

@tjbck
Copy link
Contributor

tjbck commented Dec 28, 2023

LGTM, Thanks!

@tjbck tjbck merged commit 8370465 into open-webui:main Dec 28, 2023
explorigin pushed a commit to explorigin/open-webui that referenced this pull request Feb 2, 2024
fix(model-selector): prevent saving empty default model
Makesh-Srinivasan pushed a commit to NYU-ITS/NAGA-open-webui that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants