feat: Add jvm.file_descriptor.count metric to jvm experimental metrics#2139
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Apr 18, 2025
Merged
Conversation
047bc33 to
8a2fe2d
Compare
trask
reviewed
Apr 17, 2025
SylvainJuge
reviewed
Apr 17, 2025
trask
reviewed
Apr 17, 2025
SylvainJuge
approved these changes
Apr 18, 2025
Contributor
SylvainJuge
left a comment
There was a problem hiding this comment.
LGTM, do you think we should also include jvm.file_descriptor.limit ?
From experience the open count is enough to monitor any file descriptor leak in applications, but knowing how far we are from the limit (for example when it has been set too low) could be relevant as well without being too much effort as it's already provided by the JVM.
I would suggest to do so in a separate PR though.
Member
I think we have tracking issue for this already: #1275 |
lmolkova
pushed a commit
to lmolkova/semantic-conventions
that referenced
this pull request
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1838
Changes
This adds the UNIX specific JVM metric to the specification and docs for JVM runtime metrics.
This is the first time I'm contributing to this portion of Otel so please let me know if there's any other file I need to update and any guidance maintainers would like to share!
Merge requirement checklist
[chore]