Add http request duration to SDK metrics#2007
Merged
lmolkova merged 20 commits intoopen-telemetry:mainfrom Apr 9, 2025
Merged
Conversation
JonasKunz
reviewed
Mar 19, 2025
jsuereth
reviewed
Mar 19, 2025
…ventions into requests-duration
lmolkova
reviewed
Mar 29, 2025
…ventions into requests-duration
lmolkova
reviewed
Apr 7, 2025
lmolkova
reviewed
Apr 7, 2025
…ventions into requests-duration
Contributor
Author
|
Is there something failing with the builds? Doesn't look like it's related to this pr. :O |
trask
reviewed
Apr 8, 2025
…ventions into requests-duration
lmolkova
approved these changes
Apr 8, 2025
trask
reviewed
Apr 9, 2025
trask
approved these changes
Apr 9, 2025
Member
|
@lzchen could you please resolve the conflict? It's ready to go otherwise |
…ventions into requests-duration
…c-conventions into requests-duration
Contributor
Author
|
@lmolkova |
lmolkova
pushed a commit
to lmolkova/semantic-conventions
that referenced
this pull request
May 13, 2025
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1631 and partially addresses #1906
Changes
Adds a metric to track the duration of http requests made within an exporter.
Following the discussion in this issue, I wasn't exactly sure how we want to provide more detail regarding partial success. The
error.typecan indicate that it was a partial success but we can possibly also include information about which items succeeded/failed somewhere (perhaps in another attribute).I also made the distinction of making this metric specific to
httpbut am open to defining a generic one regardless of transport protocol (we can probably have protocol + response code as additional attributes if so).Looking forward to hearing your thoughts!
Merge requirement checklist
[chore]