Adding span for invoke agent#1900
Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom Apr 22, 2025
Merged
Conversation
Contributor
|
@gyliu513 this needs rebase after the experimental -> development rename |
lmolkova
reviewed
Feb 13, 2025
Member
lmolkova
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments
1af7a29 to
b704514
Compare
Member
Author
|
@lmolkova I think I have addressed all comments here, can you help review again? Thanks! |
lmolkova
reviewed
Mar 4, 2025
lmolkova
reviewed
Mar 4, 2025
lmolkova
reviewed
Mar 4, 2025
ea49e28 to
ef12e19
Compare
lmolkova
reviewed
Mar 7, 2025
Member
Author
|
@lmolkova can you help review this again? The major change is in https://github.com/open-telemetry/semantic-conventions/pull/1900/files#diff-5183ed68de81fe666274b64e46e9c3f9fc6ea6c358abd6f9b3b3f9cb3f1c7a13 and other files are auto generated, thanks! |
lmolkova
approved these changes
Mar 25, 2025
xrmx
reviewed
Mar 27, 2025
xrmx
approved these changes
Mar 28, 2025
joaopgrassi
reviewed
Apr 9, 2025
Member
Author
|
Will update this one once #2116 got merged. |
Signed-off-by: Guangya Liu <gyliu@ibm.com>
lmolkova
approved these changes
Apr 22, 2025
Merged
via the queue into
open-telemetry:main
with commit Apr 22, 2025
0f5b12f
14 of 15 checks passed
lmolkova
pushed a commit
to lmolkova/semantic-conventions
that referenced
this pull request
May 13, 2025
Signed-off-by: Guangya Liu <gyliu@ibm.com>
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1842 #1924
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]