Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Propose "Named Tracers"#16

Merged
bogdandrutu merged 34 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:master
Sep 26, 2019
Merged

Propose "Named Tracers"#16
bogdandrutu merged 34 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:master

Conversation

@z1c0
Copy link
Contributor

@z1c0 z1c0 commented Aug 12, 2019

No description provided.

bhs
bhs reviewed Aug 12, 2019
View reviewed changes
arminru
arminru reviewed Aug 12, 2019
View reviewed changes
@ZieglerWolfgang @arminru
Apply suggestions from code review
5f7f2a0 
Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>
@z1c0 z1c0 mentioned this pull request Aug 13, 2019
Closed
arminru
arminru reviewed Aug 13, 2019
View reviewed changes
arminru
arminru reviewed Aug 13, 2019
View reviewed changes
discostu105
discostu105 reviewed Aug 14, 2019
View reviewed changes
@discostu105 discostu105 mentioned this pull request Aug 14, 2019
Closed
@pavolloffay pavolloffay mentioned this pull request Aug 16, 2019
Closed
@Oberon00 Oberon00 mentioned this pull request Sep 23, 2019
Merged
tigrannajaryan
tigrannajaryan reviewed Sep 24, 2019
View reviewed changes
@z1c0
Copy link
Contributor Author

z1c0 commented Sep 25, 2019

@bogdandrutu I'm not quite sure how we left off after yesterday's discussion in the spec meeting. Are you OK with the approach that we propose a dedicated RFC for metrics (and also logs at some later point in time) to have a better separation of concerns?
Metrics and logs get a mention in "Future possibilities" (i.e. "very near future" for metrics).

@bogdandrutu
Copy link
Member

bogdandrutu commented Sep 25, 2019

@z1c0 I would prefer to not postpone the metrics:

  1. This is a major API change that we need for Meter as well before alpha.
  2. All reasons that we need this for Trace apply to Metrics as well.
  3. We want to be consistent between Meter/Tracer in general if possible.

I suggest that we just re-write a bit the first few paragraphs to generalize the motivation for metrics as well.

Everything else stays the same:

// Create a tracer/meter for given instrumentation library in a specific version.
Tracer tracer = OpenTelemetry.getTracerFactory().getTracer("io.opentelemetry.contrib.mongodb", "semver:1.0.0");
Meter meter = OpenTelemetry.getMeterFactory().getMeter("io.opentelemetry.contrib.mongodb", "semver:1.0.0");

Also do we need a way to access unnamed Tracer/Meter?

@z1c0
Copy link
Contributor Author

z1c0 commented Sep 26, 2019

@bogdandrutu metrics are now included in this proposal.
Unnamed Tracers/Meters are mentioned in the last "Explanation" paragraph.

Oberon00
Oberon00 approved these changes Sep 26, 2019
View reviewed changes
ZieglerWolfgang and others added 3 commits September 26, 2019 13:34
@ZieglerWolfgang @Oberon00
Update text/0000-named-tracers.md
124bc83 
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
@ZieglerWolfgang @Oberon00
Update text/0000-named-tracers.md
f618455 
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
@ZieglerWolfgang
Implement latest feedback.
595f19d
tigrannajaryan
tigrannajaryan approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, subject to addressing Bogdan's comments regarding having uniform handling for Metrics as well (or a plan for it if it is not addressed in this PR).

@Oberon00
Copy link
Member

Oberon00 commented Sep 26, 2019

Seems like this is ready to merge then?

@bogdandrutu bogdandrutu merged commit ea929a7 into open-telemetry:master Sep 26, 2019
@bogdandrutu
Copy link
Member

bogdandrutu commented Sep 26, 2019

@z1c0 please in parallel start two PRs:

  1. To mark this approved.
  2. A PR to change specs accordingly.

This was referenced Sep 27, 2019
Open
Merged
Merged
@Oberon00 Oberon00 mentioned this pull request Aug 6, 2020
Closed
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
@z1c0 @bogdandrutu
Propose "Named Tracers" (open-telemetry#16)
3e5158d 
* First draft: "named tracers"

* Implement feedback.

* Move named tracers proposal into text folder

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add examples section.

* Update 0000-named-tracers.md

* Implement feedback from code review

* Remove the implementation details about enabling / disabling ... of
sensors and reduced the proposal the actual core of associating names
with tracers.:q

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Reworked this RFC based on feedback on GitHub.

* Implement latest review suggestions

* Removed formatting

* Re-introduce plain string factory and move Resource-based approach to alternatives

* Use ` to format the names in the examples.

* Fix typo and broken link

* Extended the OTEP to included Metrics as well.

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Implement latest feedback.

* Rename 0000-named-tracers.md to 0016-named-tracers.md
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
@z1c0 @bogdandrutu
Propose "Named Tracers" (open-telemetry#16)
f91f26b 
* First draft: "named tracers"

* Implement feedback.

* Move named tracers proposal into text folder

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add examples section.

* Update 0000-named-tracers.md

* Implement feedback from code review

* Remove the implementation details about enabling / disabling ... of
sensors and reduced the proposal the actual core of associating names
with tracers.:q

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Reworked this RFC based on feedback on GitHub.

* Implement latest review suggestions

* Removed formatting

* Re-introduce plain string factory and move Resource-based approach to alternatives

* Use ` to format the names in the examples.

* Fix typo and broken link

* Extended the OTEP to included Metrics as well.

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Implement latest feedback.

* Rename 0000-named-tracers.md to 0016-named-tracers.md
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
@z1c0 @bogdandrutu
Propose "Named Tracers" (open-telemetry#16)
897dc45 
* First draft: "named tracers"

* Implement feedback.

* Move named tracers proposal into text folder

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add examples section.

* Update 0000-named-tracers.md

* Implement feedback from code review

* Remove the implementation details about enabling / disabling ... of
sensors and reduced the proposal the actual core of associating names
with tracers.:q

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Reworked this RFC based on feedback on GitHub.

* Implement latest review suggestions

* Removed formatting

* Re-introduce plain string factory and move Resource-based approach to alternatives

* Use ` to format the names in the examples.

* Fix typo and broken link

* Extended the OTEP to included Metrics as well.

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Implement latest feedback.

* Rename 0000-named-tracers.md to 0016-named-tracers.md
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
@z1c0 @carlosalberto
Propose "Named Tracers" (open-telemetry/oteps#16)
75cb8c4 
* First draft: "named tracers"

* Implement feedback.

* Move named tracers proposal into text folder

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add examples section.

* Update 0000-named-tracers.md

* Implement feedback from code review

* Remove the implementation details about enabling / disabling ... of
sensors and reduced the proposal the actual core of associating names
with tracers.:q

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Reworked this RFC based on feedback on GitHub.

* Implement latest review suggestions

* Removed formatting

* Re-introduce plain string factory and move Resource-based approach to alternatives

* Use ` to format the names in the examples.

* Fix typo and broken link

* Extended the OTEP to included Metrics as well.

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Implement latest feedback.

* Rename 0000-named-tracers.md to 0016-named-tracers.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@c24t c24t Awaiting requested review from c24t

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@songy23 songy23 Awaiting requested review from songy23

@tedsuo tedsuo Awaiting requested review from tedsuo

11 more reviewers

@ajacques ajacques ajacques left review comments

@bhs bhs bhs left review comments

@yurishkuro yurishkuro yurishkuro approved these changes

@jmacd jmacd jmacd left review comments

@arminru arminru arminru left review comments

@discostu105 discostu105 discostu105 left review comments

@AloisReitbauer AloisReitbauer AloisReitbauer approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@reyang reyang reyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.