Extend the set of attribute value types#4651
Merged
lmolkova merged 90 commits intoopen-telemetry:mainfrom Oct 28, 2025
Merged
Conversation
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit c17aec6.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
carlosalberto
approved these changes
Oct 21, 2025
martincostello
approved these changes
Oct 23, 2025
Co-authored-by: Martin Costello <martin@martincostello.com>
Member
|
We'd like to get this merged today. If there's no further feedback by log sig meeting we'll merge |
trask
approved these changes
Oct 28, 2025
This was referenced Oct 28, 2025
chalin
reviewed
Oct 29, 2025
| See [this document](attribute-type-mapping.md) to find out how to map values obtained | ||
| outside OpenTelemetry into OpenTelemetry attribute values. | ||
|
|
||
| ### Standard Attribute |
Contributor
There was a problem hiding this comment.
Link checking is failing because this section has been removed, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/18904968462/job/53961074422
docs/languages/java/api/index.html
hash does not exist --- docs/languages/java/api/index.html -->
/docs/specs/otel/common/#standard-attribute
What should be used as an alternative to common/#standard-attribute? I don't see any mention of standard attributes in the page anymore. Here is an excerpt of the markdown with that link:
### Attributes
[Attributes](https://www.javadoc.io/doc/io.opentelemetry/opentelemetry-api/latest/io/opentelemetry/api/common/Attributes.html)
is a bundle of key value pairs representing the
[standard attribute definition](/docs/specs/otel/common/#standard-attribute).
`Attributes` are a recurring concept in the OpenTelemetry API:/cc @open-telemetry/docs-approvers
Contributor
There was a problem hiding this comment.
Let's track this via:
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
### Metrics - `AlignedHistogramBucketExemplarReservoir` SHOULD use a time-weighted algorithm. ([#4678](#4678)) ### Profiles - Document the profiles signal. ([#4685](#4685)) ### Common - Extend the set of attribute value types to support more complex data structures. ([#4651](#4651)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AnyValuetype supporting complex data structures (empty value, byte arrays, heterogeneous arrays and maps).AnyValuetype.Extend attribute types
Prior-art (this PR guides towards this): #4636
Prototype: open-telemetry/opentelemetry-go#6809
Follows #4614
Related to #4602
Related proto PR: open-telemetry/opentelemetry-proto#707
https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#how describes how languages should add support for new attribute value types.
Closes #4460 (no longer needed - feature is removed)
OTEP changes
Notice that this PR has changed the strategy for https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#api from:
to simply:
This is the agreement up to this point: #4651 (comment)
The other change in the OTEP is because of #4651 (comment).
Attribute limit updates
Towards #4487
This also proposes minimal and non-breaking additions for the attribute limits: https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#attribute-limits.
The proposal for attribute count limit is proposed because of #4651 (comment).
The proposal for attribute value length limit seems the most logical to me.
Comments to be addressed as followups
I am going to create issues to be created after this is PR merged: