Define handling of null and empty attribute values#459
Merged
SergeyKanzhelev merged 9 commits intoopen-telemetry:masterfrom Feb 28, 2020
Merged
Conversation
krnowak
reviewed
Feb 14, 2020
Member
There was a problem hiding this comment.
I wonder if metrics also need this kind of clarification.
CC @jmacd
Related: open-telemetry/opentelemetry-go#320
Co-Authored-By: Wolfgang Ziegler <wolfgang.ziegler@dynatrace.com>
Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com>
Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com>
f625245 to
c4beea2
Compare
SergeyKanzhelev
approved these changes
Feb 17, 2020
Oberon00
approved these changes
Feb 21, 2020
| considered meaningful and MUST be stored and passed on to span processors / exporters. | ||
| Attribute values of `null` are considered to be not set and get discarded as if | ||
| that `SetAttribute` call had never been made. | ||
| As an exception to this, if overwriting of values is supported, this results in |
Member
There was a problem hiding this comment.
if overwriting of values is supported...
The paragraph above says that attribute overwriting SHOULD be supported, so I think there is no need for this conditional.
Member
Author
There was a problem hiding this comment.
Technically it is not but I still think this clarification might avoid some potential confusion.
| This is required for map/dictionary structures represented as two arrays with | ||
| indices that are kept in sync (e.g., two attributes `header_keys` and `header_values`, | ||
| both containing an array of strings to represent a mapping | ||
| `header_keys[i] -> header_values[i]`). |
carlosalberto
approved these changes
Feb 26, 2020
Member
|
last sign off was from two days back. And we have enough sign offs. @bogdandrutu I remember you mentioned you want to use |
This was referenced Mar 4, 2020
Member
|
Looks like this could be added to the v0.4 milestone because this was merged after v0.3 was cut. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Define handling of null and empty attribute values * undefined -> not set * Apply suggestions from code review Co-Authored-By: Wolfgang Ziegler <wolfgang.ziegler@dynatrace.com> * Apply suggestions from code review Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com> * Allow exporters to replace null values in arrays * Apply suggestions from code review Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com> * attribute semantics -> restrictions * emphasize MUST Co-authored-by: Wolfgang Ziegler <wziegler@live.at> Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
…equired (open-telemetry#459) Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #431.
A follow-up PR might reference this definition for resource attributes as well to address #446.