[Logs] Add optional Event Name parameter to Logger.Enabled and LogRecordProcessor.Enabled#4489
Merged
reyang merged 6 commits intoopen-telemetry:mainfrom May 13, 2025
Merged
Conversation
cijothomas
reviewed
May 1, 2025
jsuereth
approved these changes
May 5, 2025
reyang
approved these changes
May 6, 2025
lmolkova
approved these changes
May 7, 2025
Merged
carlosalberto
added a commit
that referenced
this pull request
May 14, 2025
May 2025 Release. ### Context - Drop reference to binary `Propagator`. ([#4490](#4490)) ### Logs - Add optional `Event Name` parameter to `Logger.Enabled` and `LogRecordProcessor.Enabled`. ([#4489](#4489)) ### Resource - Add experimental resource detector name. ([#4461](#4461)) ### OTEPs - OTEP: Span Event API deprecation plan. ([#4430](#4430))
This was referenced May 27, 2025
This was referenced Jun 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
Fixes #4528 **What are you trying to achieve?** Stabilize `Event Name` parameter of [`Logger.Enabled`](https://github.com/pellared/opentelemetry-specification/blob/main/specification/logs/api.md#enabled). Implemented by: - [Rust](https://github.com/open-telemetry/opentelemetry-rust/blob/8882c31c95b37c68e29d663d4a05b1cb523d8cd7/opentelemetry-sdk/src/logs/logger.rs#L57) - [C++](https://github.com/open-telemetry/opentelemetry-cpp/blob/7a9c60994ef3d9fb7f3d7fd22d0fa3f0db743ecd/api/include/opentelemetry/logs/logger.h#L269-L276) - `EventId` encapsulates the event name - [Go](https://github.com/open-telemetry/opentelemetry-go/blob/1636bcdd1d59fd7284ee2c65ee22acd038d1e979/log/logger.go#L140) - [planned for PHP](#4528 (comment)) **Additional context.** Related issue: - #4220 Related PR: - #4489 --------- Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4220
Already used by Rust; #4220 (comment):
OTel Go prototype: open-telemetry/opentelemetry-go#6702