Add specification text for OTEP-0250#4466
Merged
carlosalberto merged 86 commits intoopen-telemetry:mainfrom Jun 16, 2025
Merged
Add specification text for OTEP-0250#4466carlosalberto merged 86 commits intoopen-telemetry:mainfrom
carlosalberto merged 86 commits intoopen-telemetry:mainfrom
Conversation
…ication into jmacd/otep235
…ication into jmacd/otep235
Co-authored-by: J. Kalyana Sundaram <kalyanaj@microsoft.com>
…ication into jmacd/otep235
…ication into jmacd/otep235
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
…ication into jmacd/otep235
Co-authored-by: Tobias Bachert <git@b-privat.de>
…ication into jmacd/otep235
…ication into jmacd/otep235
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
…ication into jmacd/otep235
…rv sub-key and th sub-key
Contributor
yuanyuanzhao3
left a comment
There was a problem hiding this comment.
This version looks pretty good to me. Just one clarifying comment and one nit.
Thanks.
oertl
approved these changes
May 23, 2025
yuanyuanzhao3
approved these changes
May 23, 2025
…ication into jmacd/otep250
carlosalberto
approved these changes
May 27, 2025
kentquirk
approved these changes
May 27, 2025
Member
kentquirk
left a comment
There was a problem hiding this comment.
We've been over this multiple times in Sampling SIG.
jsuereth
approved these changes
May 27, 2025
tsloughter
reviewed
May 27, 2025
Contributor
|
We have enough reviews. Unless big items come up this week, let's merge this PR once feedback has been addressed. |
Contributor
|
We have had enough time for reviews, along with the Sampling SIG giving its blessing. Merging. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
July 2025 release. ### Context - Add Supplementary Guidelines for environment variables as context carrier specification. ([#4548](#4548)) ### Traces - Define sampling threshold field in OpenTelemetry TraceState; define the behavior of TraceIdRatioBased sampler in terms of W3C Trace Context Level 2 randomness. ([#4166](#4166)) - Define CompositeSampler implementation and built-in ComposableSampler interfaces. ([#4466](#4466)) - Define how SDK implements `Tracer.Enabled`. ([#4537](#4537)) ### Logs - Stabilize `Event Name` parameter of `Logger.Enabled`. ([#4534](#4534)) - Stabilize SDK and No-Op `Logger.Enabled`. ([#4536](#4536)) - `SeverityNumber=0` MAY be used to represent an unspecified value. ([#4535](#4535)) ### Baggage - Add Supplementary Guidelines for environment variables as context carrier specification. ([#4548](#4548)) ### Compatibility - Clarify expectations about Prometheus content negotiation for metric names. ([#4543](#4543)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1413
Part of #173
Part of #1060
Part of #1844
Prototypes
Rust, Go, Java
https://github.com/jmacd/rust-sampler
https://github.com/jmacd/go-sampler
https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/consistent-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent56
Changes
Adds specification text for OTEP-0250, which covers CompositeSampler and related interfaces.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary