Composite Head Samplers#4321
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Added |
59612f8 to
db169b3
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
4bfaa72 to
5a3ee3b
Compare
|
Overall LGTM, just left a few questions. Also, is the plan that languages implement all of these samplers? There's no requirement anywhere but I'm curious on the expectation, e.g. what if at least consistent and consistentparentbased should be supported? |
Good question, this has not been discussed yet, but if we assume that the example is realistic, we probably need all of them. I think we should say that an OTel SDK SHOULD implement them all. |
|
Forgot to mention all the sampling OTEPs are under |
|
I think we can go ahead and merge this @PeterF778 . Probably only consider moving this OTEP under |
#4321 needs a CHANGELOG entry.
|
FYI A new prototype has been written in OTel-Rust: The portion of this OTEP that my two prototypes (Go and Rust) do not include, thus far, is a rate-limited sampler. I will suggest we (sampling SIG) prototype the rate-limited sampler as we work to propose updates to the spec to reflect this OTEP. Thank you @PeterF778! |
Changes
Migrating from open-telemetry/oteps#250.
This is another approach for introducing Composite (Head) Samplers. The previous one (open-telemetry/oteps#240) proved too large, with some controversial elements.
This OTEP is a split-off from that one, focusing just on one area - new Composite Samplers.
Two prototypes exist for this functionality. We are seeking a third prototype.
In the Java-contrib repo: https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/consistent-sampling/README.md
In @jmacd's https://github.com/jmacd/go-sampler/blob/main/README.md.