Clarify OTEL_LOG_LEVEL is to control internal logging#4267
Merged
reyang merged 1 commit intoopen-telemetry:mainfrom Oct 21, 2024
Merged
Clarify OTEL_LOG_LEVEL is to control internal logging#4267reyang merged 1 commit intoopen-telemetry:mainfrom
reyang merged 1 commit intoopen-telemetry:mainfrom
Conversation
marcalff
approved these changes
Oct 21, 2024
pellared
approved these changes
Oct 21, 2024
dashpole
approved these changes
Oct 21, 2024
svrnm
approved these changes
Oct 21, 2024
MrAlias
approved these changes
Oct 21, 2024
codeboten
approved these changes
Oct 21, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
kaylareopelle
added a commit
to kaylareopelle/opentelemetry-specification
that referenced
this pull request
Oct 1, 2025
When reading through open-telemetry#4267, I noticed that the Probability Sampler description still had a reference to ratio-based. I think that entire section may be cut since the clarifications were specifically related to the old name. Also, found a small typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Trying to make it more obvious that OTEL_LOG_LEVEL is to control SDK's own internal logging level. (As opposed to controlling the levels in LogBridge)
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary