Update Instrumentation Scope glossary entry with correct identifying fields#4244
Merged
carlosalberto merged 5 commits intoopen-telemetry:mainfrom Oct 9, 2024
Merged
Conversation
08e09ce to
31a7b4a
Compare
31a7b4a to
e0b9b46
Compare
reyang
approved these changes
Oct 3, 2024
cijothomas
approved these changes
Oct 3, 2024
dashpole
approved these changes
Oct 4, 2024
pellared
approved these changes
Oct 4, 2024
svrnm
approved these changes
Oct 8, 2024
jsuereth
approved these changes
Oct 8, 2024
carlosalberto
approved these changes
Oct 8, 2024
Member
|
@aabmass would you update the changelog? Thanks! |
Member
Author
Sure, I added it to the common section. Hope that's OK |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…fields (open-telemetry#4244) Small follow up to open-telemetry#4161 ## Changes Updates the glossary to indicate that instrumentation scope's schema url and attributes are also identifying. I simplified the language a bit. * [x] Related issues open-telemetry#4160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow up to #4161
Changes
Updates the glossary to indicate that instrumentation scope's schema url and attributes are also identifying. I simplified the language a bit.