Transition plan for HTTP breaking changes where both old and new attributes can be sent for a while#3443
Conversation
e17c02f to
5442c9a
Compare
5442c9a to
1382c50
Compare
|
If double publishing is optional, how should users configure it? Should we define an ENV VAR? |
|
Perhaps, alternatively, |
|
I'm worried about trying to create something general (and opening more new questions). What if we go in the other direction and make it clear that this environment variable is super-targeted to this one-time transition, e.g. something like:
|
+1 👍 |
|
or maybe |
Co-authored-by: Ram Thiru <ramthi@users.noreply.github.com>
|
@tigrannajaryan @arminru @jmacd @dyladan can you take another look at this? thx! |
dyladan
left a comment
There was a problem hiding this comment.
Seems OK. I guess my only question left is how do we handle future breaks when, for example, messaging is updated? Will the env var accept multiple values like http,messaging/dup?
|
think this is the best version of the transition plan i've seen yet |
my thought is |
I think if we take an all or nothing break approach we will have 2 big problems:
I think given those drawbacks we basically have to do this piece by piece approach unfortunately. |
@dyladan I think @tedsuo's concern was regarding the earlier approach which was using the super-specific env var |
tedsuo
left a comment
There was a problem hiding this comment.
This looks great. Thank you Trask and everyone for the thought put into this; I now feel confident with us moving forward with semconv stability in general.
…ibutes can be sent for a while (open-telemetry#3443)
…ibutes can be sent for a while (open-telemetry#3443)
Fixes #3362
Alternative to #3404
Changes
Adds transition plan for upcoming breaking changes to the unstable HTTP semantic conventions.