Update aws lambda spec to remove X-Ray Env propagation by tylerbenson · Pull Request #3166 · open-telemetry/opentelemetry-specification

tylerbenson · 2023-02-01T21:19:55Z

Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators.

~~We also decided that EventToCarrier should be specified in the spec to improve cross language instrumentation consistency.~~

I removed EventToCarrier from this PR to focus on the x-ray propagation. We can revisit in a separate PR.

Fixes #3060

Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators. We also decided that `EventToCarrier` should be specified in the spec to improve cross language instrumentation consistency.

specification/trace/semantic_conventions/instrumentation/aws-lambda.md

Co-authored-by: Tristan Sloughter <t@crashfast.com>

Pulled section about EventToCarrier for further discussion.

tylerbenson · 2023-02-02T16:05:32Z

@Aneurysm9 note: I pulled the section about EventToCarrier as it was causing some confusion. We should discuss further and put in a separate PR for it.

specification/trace/semantic_conventions/instrumentation/aws-lambda.md

cartersocha · 2023-02-07T20:08:50Z

fyi @tedsuo we have a spec reviewer block here

cartersocha · 2023-02-07T20:13:53Z

Approved by AWS Lambdas SME's - @Aneurysm9

cartersocha · 2023-02-07T20:15:07Z

No GCP or Azure SME input required

specification/trace/semantic_conventions/instrumentation/aws-lambda.md

…ambda.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

tigrannajaryan · 2023-02-08T19:55:39Z

This has enough approvals but merging is blocked because there are unresolved conversations.

tylerbenson · 2023-02-08T21:43:29Z

@tigrannajaryan thanks for the call-out. I've resolved the remaining conversation. Should be good to go!

See open-telemetry/opentelemetry-specification#3166

open-telemetry/opentelemetry-specification#3166 Per discussion in the FAAS SIG, we decided that the AWS X-Ray environment variable should be moved to a span link to avoid interfering with the configured propagators.

…7970) open-telemetry/opentelemetry-specification#3166 Per discussion in the FAAS SIG, we decided that the AWS X-Ray environment variable should be moved to a span link to avoid interfering with the configured propagators. Also related to #5167.

wangzlei · 2023-08-17T17:13:16Z

This spec changes might be against with Span links spec and Messaging system. FYI the ambient case in https://github.com/open-telemetry/oteps/blob/main/text/trace/0220-messaging-semantic-conventions-span-structure.md#user-content-instrumenting-pull-based-scenarios. If user's Lambda function is invoked by AWS Lambda, AWS Lambda should be the parent of user Lambda function.
AWS Lambda is working on the passthrough mode fix and would be released soon. After this fix, if user disables tracing for a root Lambda, the environment does not have trace header with sample flag 0.

May I know the deeper reason why changing parent-child to be links?

tylerbenson · 2023-08-17T18:37:02Z

@wangzlei This PR is probably not the best place to have this discussion. Can I suggest you open a new issue or join the FAAS SIG meeting?

The quick summary is that the prior behavior would break traces for other vendors when x-ray was enabled because the x-ray internal spans were not available.

carlosalberto · 2023-08-17T18:45:53Z

@wangzlei As Tyler said, please open an issue in https://github.com/open-telemetry/semantic-conventions (and maybe join the FaaS call? We meet every Thursday at 8am Pacific)

…y#3166) * Update aws lambda spec to remove X-Ray Env propagation Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators.

tylerbenson requested review from a team February 1, 2023 21:19

github-actions bot assigned arminru Feb 1, 2023

Aneurysm9 approved these changes Feb 1, 2023

View reviewed changes

specification/trace/semantic_conventions/instrumentation/aws-lambda.md Outdated Show resolved Hide resolved

codeboten reviewed Feb 1, 2023

View reviewed changes

Apply review suggestions.

af2298c

tsloughter reviewed Feb 1, 2023

View reviewed changes

specification/trace/semantic_conventions/instrumentation/aws-lambda.md Show resolved Hide resolved

tylerbenson and others added 2 commits February 1, 2023 17:09

Add links to links :-)

f8be2b6

Co-authored-by: Tristan Sloughter <t@crashfast.com>

More review changes

85c0d9d

Pulled section about EventToCarrier for further discussion.

tsloughter approved these changes Feb 1, 2023

View reviewed changes

fix lint checks

54ef1a0

codeboten approved these changes Feb 2, 2023

View reviewed changes

carlosalberto approved these changes Feb 2, 2023

View reviewed changes

ronyis reviewed Feb 5, 2023

View reviewed changes

specification/trace/semantic_conventions/instrumentation/aws-lambda.md Show resolved Hide resolved

MrAlias reviewed Feb 7, 2023

View reviewed changes

specification/trace/semantic_conventions/instrumentation/aws-lambda.md Outdated Show resolved Hide resolved

specification/trace/semantic_conventions/instrumentation/aws-lambda.md Outdated Show resolved Hide resolved

tylerbenson and others added 3 commits February 8, 2023 11:08

Update specification/trace/semantic_conventions/instrumentation/aws-l…

959dec9

…ambda.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update specification/trace/semantic_conventions/instrumentation/aws-l…

73cfa16

…ambda.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Merge branch 'main' into tyler/lambda

a28f747

MrAlias approved these changes Feb 8, 2023

View reviewed changes

Merge branch 'main' into tyler/lambda

e448e5d

tsloughter mentioned this pull request Feb 10, 2023

update awslambda to use _X_AMZN_TRACE_ID as a Span Link open-telemetry/opentelemetry-python-contrib#1657

Merged

11 tasks

tylerbenson force-pushed the tyler/lambda branch from ad7244f to 7c30584 Compare February 10, 2023 15:41

Add CHANGELOG entry.

744bb9f

tylerbenson force-pushed the tyler/lambda branch from 7c30584 to 744bb9f Compare February 10, 2023 15:50

Merge branch 'main' into tyler/lambda

f5fc736

carlosalberto merged commit 7116e72 into open-telemetry:main Feb 10, 2023

tylerbenson deleted the tyler/lambda branch February 10, 2023 17:33

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

68ca172

See open-telemetry/opentelemetry-specification#3166

tsloughter mentioned this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent open-telemetry/opentelemetry-go-contrib#3428

Closed

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

94b3e70

See open-telemetry/opentelemetry-specification#3166

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

4746424

See open-telemetry/opentelemetry-specification#3166

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

e95cdf9

See open-telemetry/opentelemetry-specification#3166

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

e478429

See open-telemetry/opentelemetry-specification#3166

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

6037833

See open-telemetry/opentelemetry-specification#3166

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 24, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

05b949c

See open-telemetry/opentelemetry-specification#3166

tsloughter added a commit to tsloughter/opentelemetry-go-contrib that referenced this pull request Feb 25, 2023

lambda: use _X_AMZN_TRACE_ID trace context as a Link not parent

67d1ded

See open-telemetry/opentelemetry-specification#3166

tylerbenson mentioned this pull request Mar 3, 2023

Move X-Ray Env Variable propagation to span link instead of parent open-telemetry/opentelemetry-java-instrumentation#7970

Merged

MrAlias mentioned this pull request Mar 6, 2023

Generate v1.19.0 semconv open-telemetry/opentelemetry-go#3842

Closed

martinkuba mentioned this pull request Mar 23, 2023

feat(instrumentation-aws-lambda): Changed capturing of X-Ray context as span link open-telemetry/opentelemetry-js-contrib#1411

Closed

tylerbenson mentioned this pull request Jul 17, 2023

AWS X-Ray Environment Variable Propagation #3605

Closed

jsuereth mentioned this pull request Aug 21, 2023

FaaS: Change requirements regarding handling of AWS Lambda-provided SpanContext open-telemetry/semantic-conventions#272

Closed

Aneurysm9 mentioned this pull request Aug 21, 2023

Faas: Add an option to use the X-Ray env var as main parent. open-telemetry/semantic-conventions#263

Closed

tylerbenson mentioned this pull request Aug 22, 2023

AWS Lambda spec inappropriately prioritizes x-ray propagation #3060

Closed

Conversation

tylerbenson commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tylerbenson commented Feb 2, 2023

Uh oh!

Uh oh!

cartersocha commented Feb 7, 2023

Uh oh!

cartersocha commented Feb 7, 2023

Uh oh!

cartersocha commented Feb 7, 2023

Uh oh!

Uh oh!

Uh oh!

tigrannajaryan commented Feb 8, 2023

Uh oh!

tylerbenson commented Feb 8, 2023

Uh oh!

wangzlei commented Aug 17, 2023

Uh oh!

tylerbenson commented Aug 17, 2023

Uh oh!

carlosalberto commented Aug 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

tylerbenson commented Feb 1, 2023 •

edited

Loading